TT-653 - TT-653-Time-Entries-Incorrect-Message #858

almeida-erick · 2022-05-10T06:51:27Z

No description provided.

sonarqubecloud · 2022-05-10T06:52:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

codecov · 2022-05-10T06:55:40Z

Codecov Report

Merging #858 (b806c19) into master (df9071c) will decrease coverage by 0.04%.
The diff coverage is 90.69%.

❗ Current head b806c19 differs from pull request most recent head 047f7b8. Consider uploading reports for the commit 047f7b8 to get more accurate results

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
- Coverage   97.48%   97.44%   -0.05%     
==========================================
  Files         107      109       +2     
  Lines        2430     2464      +34     
  Branches      203      205       +2     
==========================================
+ Hits         2369     2401      +32     
  Misses         23       23              
- Partials       38       40       +2

Impacted Files	Coverage Δ
...s/parse-date-time-offset/parse-date-time-offset.ts	`33.33% <33.33%> (ø)`
.../components/entry-fields/entry-fields.component.ts	`95.83% <50.00%> (-1.35%)`	⬇️
...nents/time-range-form/time-range-form.component.ts	`93.33% <66.66%> (-6.67%)`	⬇️
...-management/store/activity-management.selectors.ts	`90.00% <100.00%> (+1.11%)`	⬆️
...time-entries-table/time-entries-table.component.ts	`100.00% <100.00%> (+8.69%)`	⬆️
...c/app/modules/reports/models/total-hours-report.ts	`100.00% <100.00%> (ø)`
src/app/modules/reports/pages/reports.component.ts	`100.00% <100.00%> (ø)`
...ponents/details-fields/details-fields.component.ts	`98.08% <100.00%> (ø)`
...dules/time-entries/pages/time-entries.component.ts	`95.65% <100.00%> (+0.03%)`	⬆️
...sers/components/users-list/users-list.component.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995c504...047f7b8. Read the comment docs.

github-actions · 2022-05-10T06:58:55Z

[infrastructure/][stage] Terraform Plan 📖 `success`

Show Plan

```

terraform
module.ui.azurerm_app_service_plan.appserviceplan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.app_service: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

module.ui.azurerm_app_service.app_service has changed

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
+ tags = {}
# (17 unchanged attributes hidden)

  ~ logs {
        # (2 unchanged attributes hidden)


      ~ http_logs {

          + file_system {
              + retention_in_days = 0
              + retention_in_mb   = 35
            }
        }
        # (1 unchanged block hidden)
    }

  ~ site_config {
      + default_documents                    = []
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (2 unchanged blocks hidden)
}

module.ui.azurerm_app_service_plan.appserviceplan[0] has changed

~ resource "azurerm_app_service_plan" "appserviceplan" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
+ tags = {}
# (9 unchanged attributes hidden)

    # (1 unchanged block hidden)
}

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.app_service will be updated in-place

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @almeida-erick, Action: `pull_request`*

github-actions · 2022-05-10T06:58:56Z

[infrastructure/][prod] Terraform Plan 📖 `success`

Show Plan

```

terraform
module.ui.azurerm_app_service_plan.appserviceplan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod]
module.ui.azurerm_app_service.app_service: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

module.ui.azurerm_app_service.app_service has changed

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod"
name = "time-tracker-ui-prod"
+ tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      + default_documents                    = []
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

module.ui.azurerm_app_service_plan.appserviceplan[0] has changed

~ resource "azurerm_app_service_plan" "appserviceplan" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod"
name = "time-tracker-ui-prod"
+ tags = {}
# (9 unchanged attributes hidden)

    # (1 unchanged block hidden)
}

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.app_service will be updated in-place

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod"
name = "time-tracker-ui-prod"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @almeida-erick, Action: `pull_request`*

FranLMSP · 2022-05-10T14:30:52Z

src/app/modules/shared/formatters/parse-date-time-offset/parse-date-time-offset.ts

-    if(date == null || date == undefined || date == '') return 'In progress';
-    return moment.utc(date).utcOffset(-1*offset).format("HH:mm");
+  parseDateTimeOffset(date: string, offset): string {
+    if (date === null || date === undefined || date === '') {


I'm just curious, why not if (!date) here?

I also noticed that offset doesn't have typing, I think it's a number offset: number

Well that code was already here, I just changed the format that was complaining when I tried to do a commit.
The change related to this task is on this file

src/app/modules/shared/components/details-fields/details-fields.component.ts

But what you are suggesting seems logical to me, do you think we need another task to "clean up" the code ?

these would be small refactors so you can fit them here if you want yeah, if you are going to do so just make sure that it's well tested to not break anything :P

I just add here what the plugin used for checking the code was asking, which is adding blank spaces, or adding brackets in an "if", as you mentioned refactoring the code in this case is small, but could break something, and I feel comfortable doing them in another task IMO :p .

fix: TT-653 Add condition when someone is currently working on a task

047f7b8

FranLMSP reviewed May 10, 2022

View reviewed changes

almeida-erick closed this May 10, 2022

almeida-erick deleted the TT-653-Time-Entries-Incorrect-Message branch May 10, 2022 18:29

TT-653 - TT-653-Time-Entries-Incorrect-Message #858

TT-653 - TT-653-Time-Entries-Incorrect-Message #858

Uh oh!

Conversation

almeida-erick commented May 10, 2022

Uh oh!

sonarqubecloud bot commented May 10, 2022

Uh oh!

codecov bot commented May 10, 2022

Codecov Report

Uh oh!

github-actions bot commented May 10, 2022

[infrastructure/][stage] Terraform Plan 📖 success

module.ui.azurerm_app_service.app_service has changed

module.ui.azurerm_app_service_plan.appserviceplan[0] has changed

module.ui.azurerm_app_service.app_service will be updated in-place

Uh oh!

github-actions bot commented May 10, 2022

[infrastructure/][prod] Terraform Plan 📖 success

module.ui.azurerm_app_service.app_service has changed

module.ui.azurerm_app_service_plan.appserviceplan[0] has changed

module.ui.azurerm_app_service.app_service will be updated in-place

Uh oh!

FranLMSP May 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FranLMSP May 10, 2022

Choose a reason for hiding this comment

Uh oh!

almeida-erick May 10, 2022

Choose a reason for hiding this comment

Uh oh!

FranLMSP May 10, 2022

Choose a reason for hiding this comment

Uh oh!

almeida-erick May 10, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[infrastructure/][stage] Terraform Plan 📖 `success`

[infrastructure/][prod] Terraform Plan 📖 `success`

FranLMSP May 10, 2022 •

edited

Loading