Skip to content

Conversation

@almeida-erick
Copy link
Contributor

Remove redundancies for defining environment variables in Docker-Compose and the Makefile

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #843 (fe235a9) into master (df9071c) will decrease coverage by 0.19%.
The diff coverage is 58.82%.

❗ Current head fe235a9 differs from pull request most recent head e04b607. Consider uploading reports for the commit e04b607 to get more accurate results

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
- Coverage   97.48%   97.29%   -0.20%     
==========================================
  Files         107      107              
  Lines        2430     2441      +11     
  Branches      203      204       +1     
==========================================
+ Hits         2369     2375       +6     
- Misses         23       28       +5     
  Partials       38       38              
Impacted Files Coverage Δ
src/app/modules/reports/pages/reports.component.ts 50.00% <0.00%> (-50.00%) ⬇️
...nents/time-range-form/time-range-form.component.ts 86.66% <33.33%> (-13.34%) ⬇️
...time-entries-table/time-entries-table.component.ts 87.09% <66.66%> (-4.21%) ⬇️
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da1792f...e04b607. Read the comment docs.

@github-actions
Copy link

[infrastructure/][stage] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.appserviceplan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage]
module.ui.azurerm_app_service.app_service: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

module.ui.azurerm_app_service.app_service has changed

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
+ tags = {}
# (17 unchanged attributes hidden)

  ~ logs {
        # (2 unchanged attributes hidden)


      ~ http_logs {

          + file_system {
              + retention_in_days = 0
              + retention_in_mb   = 35
            }
        }
        # (1 unchanged block hidden)
    }

  ~ site_config {
      + default_documents                    = []
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (2 unchanged blocks hidden)
}

module.ui.azurerm_app_service_plan.appserviceplan[0] has changed

~ resource "azurerm_app_service_plan" "appserviceplan" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/serverfarms/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
+ tags = {}
# (9 unchanged attributes hidden)

    # (1 unchanged block hidden)
}

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.app_service will be updated in-place

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-stage/providers/Microsoft.Web/sites/time-tracker-ui-stage"
name = "time-tracker-ui-stage"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @almeida-erick, Action: `pull_request`*

@github-actions
Copy link

[infrastructure/][prod] Terraform Plan 📖 success

Show Plan ```

terraform
module.ui.azurerm_app_service_plan.appserviceplan[0]: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod]
module.ui.azurerm_app_service.app_service: Refreshing state... [id=/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod]

Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply":

module.ui.azurerm_app_service.app_service has changed

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod"
name = "time-tracker-ui-prod"
+ tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      + default_documents                    = []
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

module.ui.azurerm_app_service_plan.appserviceplan[0] has changed

~ resource "azurerm_app_service_plan" "appserviceplan" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/serverfarms/time-tracker-ui-prod"
name = "time-tracker-ui-prod"
+ tags = {}
# (9 unchanged attributes hidden)

    # (1 unchanged block hidden)
}

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place

Terraform will perform the following actions:

module.ui.azurerm_app_service.app_service will be updated in-place

~ resource "azurerm_app_service" "app_service" {
id = "/subscriptions/ca70c44c-ad7a-4333-a22c-07ebc6a69224/resourceGroups/time-tracker-service-prod/providers/Microsoft.Web/sites/time-tracker-ui-prod"
name = "time-tracker-ui-prod"
tags = {}
# (17 unchanged attributes hidden)

  ~ site_config {
      ~ linux_fx_version                     = (sensitive)
        # (29 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

    # (3 unchanged blocks hidden)
}

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

</details>
*Pusher: @almeida-erick, Action: `pull_request`*

@faustocv
Copy link
Collaborator

@Erick Almeida I thought that you were fixing this file https://github.com/ioet/time-tracker-ui/blob/master/scripts/setenv.ts and not create a new script

Copy link
Collaborator

@faustocv faustocv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@almeida-erick almeida-erick deleted the TT-610-Time-Tracker-Keys branch April 14, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants