Skip to content

TT-593 On Reports page, add filter by user name #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 28, 2022
Merged

TT-593 On Reports page, add filter by user name #839

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
601da91
feat: TT-593 add filter for searching a specific user
codigodehoy Mar 29, 2022
1d79433
feat: TT-593 added the ngOnChanges event
codigodehoy Mar 30, 2022
bd407e2
style: TT-593 added the length of the search button
wilc0519 Mar 29, 2022
4708862
fix: TT-593 resolved keys
wilc0519 Mar 30, 2022
7e0c9db
fix: TT-593 added the time-tracker-ui CD-prod file
wilc0519 Mar 30, 2022
832bf7a
fix: TT-593 added the time-tracker-ui-cd-prod file
wilc0519 Mar 30, 2022
dede01b
fix: TT-593 fixed the CI-time-tracker-ui.yml file
codigodehoy Apr 6, 2022
a58b78a
fix: TT-593 refactor
wilc0519 Apr 20, 2022
63c9ead
Merge branch 'master' into TT-593-on-reports-page-add-filter-by-user-…
wilc0519 Apr 20, 2022
504c500
Merge branch 'TT-593-on-reports-page-add-filter-by-user-name' of gith…
wilc0519 Apr 20, 2022
6e55792
fix: TT-593 refactor
wilc0519 Apr 20, 2022
91f5114
fix: TT-593 unit test
wilc0519 Apr 22, 2022
d8bdea8
fix: TT-593 refactor unit tets
wilc0519 Apr 22, 2022
986fd43
fix: TT-539 conflict resolution
wilc0519 Apr 22, 2022
1d5656a
fix: TT-593 unit test coverage
wilc0519 Apr 27, 2022
6bedc07
fix: TT-593 unit test implementation
wilc0519 Apr 27, 2022
b9ea8e9
fix: TT-593 coverage time-entries-table
wilc0519 Apr 28, 2022
17208d2
fix: TT-593 coverage time-entries-table
wilc0519 Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-593 refactor unit tets
  • Loading branch information
@wilc0519
wilc0519 committed Apr 22, 2022
commit d8bdea8b891b8cab92c3f24f1f8068a8d2216942
2 changes: 1 addition & 1 deletion src/app/modules/reports/components/time-entries-table/time-entries-table.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ describe('Reports Page', () => {

it(`When the user method is called, the emit method is called`, () => {
const userId = 'abc123';
spyOn(component.selectedUserId,'emit');
spyOn(component.selectedUserId, 'emit');
component.user(userId);
expect(component.selectedUserId.emit).toHaveBeenCalled();

Expand Down
2 changes: 1 addition & 1 deletion src/app/modules/reports/components/time-range-form/time-range.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe('Reports Page', () => {
expect(component.onSubmit).toHaveBeenCalled();
});

it('When the ngOnChanges method is called, the onSubmit method is called', () =>{
it('When the ngOnChanges method is called, the onSubmit method is called', () => {
const userId = 'abcd';
spyOn(component, 'onSubmit');

Expand Down