-
Notifications
You must be signed in to change notification settings - Fork 1
Tt 513 create ci/cd pipeline in timer tracker UI to deploy changes for both environments #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tt 513 create ci/cd pipeline in timer tracker UI to deploy changes for both environments #833
Conversation
author Heiker Gil <[email protected]> 1646927329 -0500 committer Santiago Atapuma <[email protected]> 1647463991 -0500 parent bf8977e author Heiker Gil <[email protected]> 1646927329 -0500 committer Santiago Atapuma <[email protected]> 1647463401 -0500 fix: TT-513 CI/CD fix files feat: TT-513 cd-stage workflows feat: TT-513 fix indent cd-stage.yml feat: TT-513 fix indent cd-stage.yml fix: TT-513 fix indent cd-stage.yml feat: TT-513 add ci.yml feat: TT-513 add ci.yml fix: TT-513 fix ci.yml fix: TT-513 ci.yml feat: TT-513 add cd-prod.yml Update time-tracker-ui-ci.yml fix: TT-513 ci.yml Update time-tracker-ui-ci.yml feat: TT-513 environment variables fix: TT-513 .env variables fix: TT-513 env variables fix: TT-513 fix make file fix: TT-513 install chrome with dockerfile fix: TT-513 install chrome on docker container fix: TT-513 fix docker file fix: karma.conf.js to run headless fix: TT-513 change tests to ci-test scrip fix: TT-513 fix docker file fix: TT-513 karma testing fix: TT-513 add chrome to docker img fix: TT-513 change chrome download url fix: TT-513 fix chorme install fix: TT-513 change make to ci-test fix: TT-513 fix coverage fix: TT-513 fix permissions fix: TT-513 Fix Permissions in home fix: TT-513 fix permissions fix: TT-513 fix permissions fix: TT-573 fix permission} fix: TT-513 fix permissions fix: TT-573 fix permissions fix: TT-513 Fix permissions fix: TT-513 fix permissions fix: TT-513 Fix Permissions fix: TT-513 Fix Permissions fix: TT-513 Permissions fix: TT-513 disable karma coverage test fix: TT-513 Fix CLI
…loy-changes-for-both-environments' of https://github.com/ioet/time-tracker-ui into TT-513-Create-CI/CD-pipeline-in-timer-tracker-ui-to-deploy-changes-for-both-environments
…loy-changes-for-both-environments' of https://github.com/ioet/time-tracker-ui into TT-513-Create-CI/CD-pipeline-in-timer-tracker-ui-to-deploy-changes-for-both-environments pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Dockerfile
Outdated
| RUN touch /var/run/nginx.pid && chown -R ${USERNAME}:${USERNAME} /var/run/nginx.pid | ||
|
|
||
| USER ${USERNAME} | ||
| #USER ${USERNAME} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment needed?
| creds: ${{ secrets.AZURE_CREDENTIALS }} | ||
| - name: Build the docker image | ||
| run: make build | ||
| - name: Publish docker image to stage azure container registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this step is throwing an error on GitHub Actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some unused variables, continue on failure scenarios and commented code found.
2235481 to
43042db
Compare
rebase with master
rebase master
|
Kudos, SonarCloud Quality Gate passed!
|








No description provided.