Skip to content

Conversation

@santii90ec
Copy link
Contributor

No description provided.

jatobrun and others added 23 commits March 8, 2022 16:25
author Heiker Gil <[email protected]> 1646927329 -0500
committer Santiago Atapuma <[email protected]> 1647463991 -0500

parent bf8977e
author Heiker Gil <[email protected]> 1646927329 -0500
committer Santiago Atapuma <[email protected]> 1647463401 -0500

fix: TT-513 CI/CD fix files

feat: TT-513 cd-stage workflows

feat: TT-513 fix indent cd-stage.yml

feat: TT-513 fix indent cd-stage.yml

fix: TT-513 fix indent cd-stage.yml

feat: TT-513 add ci.yml

feat: TT-513 add ci.yml

fix: TT-513 fix ci.yml

fix: TT-513 ci.yml

feat: TT-513 add cd-prod.yml

Update time-tracker-ui-ci.yml

fix: TT-513 ci.yml

Update time-tracker-ui-ci.yml

feat: TT-513 environment variables

fix: TT-513 .env variables

fix: TT-513 env variables

fix: TT-513 fix make file

fix: TT-513 install chrome with dockerfile

fix: TT-513 install chrome on docker container

fix: TT-513 fix docker file

fix: karma.conf.js to run headless

fix: TT-513 change tests to ci-test scrip

fix: TT-513 fix docker file

fix: TT-513 karma testing

fix: TT-513 add chrome to docker img

fix: TT-513 change chrome download url

fix: TT-513 fix chorme install

fix: TT-513 change make to ci-test

fix: TT-513 fix coverage

fix: TT-513 fix permissions

fix: TT-513 Fix Permissions in home

fix: TT-513 fix permissions

fix: TT-513 fix permissions

fix: TT-573 fix permission}

fix: TT-513 fix permissions

fix: TT-573 fix permissions

fix: TT-513 Fix permissions

fix: TT-513 fix permissions

fix: TT-513 Fix Permissions

fix: TT-513 Fix Permissions

fix: TT-513 Permissions

fix: TT-513 disable karma coverage test

fix: TT-513 Fix CLI
…loy-changes-for-both-environments' of https://github.com/ioet/time-tracker-ui into TT-513-Create-CI/CD-pipeline-in-timer-tracker-ui-to-deploy-changes-for-both-environments
…loy-changes-for-both-environments' of https://github.com/ioet/time-tracker-ui into TT-513-Create-CI/CD-pipeline-in-timer-tracker-ui-to-deploy-changes-for-both-environments

pull
Copy link
Contributor

@rofarinango rofarinango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

Dockerfile Outdated
RUN touch /var/run/nginx.pid && chown -R ${USERNAME}:${USERNAME} /var/run/nginx.pid

USER ${USERNAME}
#USER ${USERNAME}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment needed?

creds: ${{ secrets.AZURE_CREDENTIALS }}
- name: Build the docker image
run: make build
- name: Publish docker image to stage azure container registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this step is throwing an error on GitHub Actions

Copy link

@ernestomancebo ernestomancebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some unused variables, continue on failure scenarios and commented code found.

@santii90ec santii90ec force-pushed the TT-513-Create-CI/CD-pipeline-in-timer-tracker-ui-to-deploy-changes-for-both-environments branch from 2235481 to 43042db Compare March 23, 2022 22:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@faustocv faustocv self-requested a review March 24, 2022 21:37
@santii90ec santii90ec merged commit 65a191a into master Mar 25, 2022
@santii90ec santii90ec deleted the TT-513-Create-CI/CD-pipeline-in-timer-tracker-ui-to-deploy-changes-for-both-environments branch March 25, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants