#67 delete activities #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macrisguncay
reviewed
Apr 7, 2020
src/app/modules/activities-management/store/activity-management.actions.ts
Outdated
Show resolved
Hide resolved
src/app/modules/activities-management/store/activity-management.effects.ts
Outdated
Show resolved
Hide resolved
macrisguncay
reviewed
Apr 7, 2020
| case ActivityManagementActionTypes.DELETE_ACTIVITY: { | ||
| return { | ||
| ...state, | ||
| message: 'Activity removed successfully!', |
There was a problem hiding this comment.
you need to set the loading variable to true.
There was a problem hiding this comment.
@daros10 you don't need to add "message: 'Activity removed successfully!'," that is only in DELETE_ACTIVITY_SUCCESS
jorgecod
reviewed
Apr 7, 2020
src/app/modules/activities-management/store/activity-management.actions.ts
Outdated
Show resolved
Hide resolved
macrisguncay
reviewed
Apr 7, 2020
| case ActivityManagementActionTypes.DELETE_ACTIVITY: { | ||
| return { | ||
| ...state, | ||
| message: 'Activity removed successfully!', |
There was a problem hiding this comment.
@daros10 you don't need to add "message: 'Activity removed successfully!'," that is only in DELETE_ACTIVITY_SUCCESS
| return { | ||
| data: [], | ||
| isLoading: false, | ||
| message: 'Something went wrong creating activities!', |
There was a problem hiding this comment.
the message is wrong "Something went wrong creating activities!" change for deleting
daros10
force-pushed
the
67-deletee-activities
branch
from
f4dbdc4 to
2d40594
Compare
enriquezrene
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.