Skip to content

Conversation

@rofarinango
Copy link
Contributor

Modification to fix the pagination error when change month with no data to month with data. Pagination is now keep displaying.

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #801 (1ac0134) into master (95d1ed3) will increase coverage by 1.75%.
The diff coverage is 95.81%.

❗ Current head 1ac0134 differs from pull request most recent head cb2880e. Consider uploading reports for the commit cb2880e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
+ Coverage   95.64%   97.40%   +1.75%     
==========================================
  Files         107      107              
  Lines        2273     2427     +154     
  Branches      175      203      +28     
==========================================
+ Hits         2174     2364     +190     
+ Misses         54       23      -31     
+ Partials       45       40       -5     
Impacted Files Coverage Δ
...er-management/store/customer-management.effects.ts 100.00% <ø> (ø)
src/app/modules/time-clock/store/entry.effects.ts 98.14% <ø> (+1.85%) ⬆️
src/environments/environment.ts 100.00% <ø> (ø)
...eate-project-type/create-project-type.component.ts 96.96% <50.00%> (-3.04%) ⬇️
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...c/app/modules/time-clock/services/entry.service.ts 96.42% <75.00%> (-3.58%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 96.42% <83.33%> (+4.76%) ⬆️
...ts/projects/components/services/project.service.ts 94.11% <85.71%> (+3.20%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 90.90% <90.90%> (-4.55%) ⬇️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d283ed7...cb2880e. Read the comment docs.

@LuisMS7
Copy link
Contributor

LuisMS7 commented Jan 28, 2022

Review the codecov/path process and why it is failing.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rofarinango rofarinango merged commit 6a137a0 into master Jan 31, 2022
@rofarinango rofarinango deleted the TT-362-Pagination-is-not-displayed branch January 31, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants