#64 get, create and edit projects #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgecod
commented
Apr 7, 2020
jorgecod
commented
- Get, Create and Edit Users
enriquezrene
suggested changes
Apr 7, 2020
src/app/app.module.ts
Outdated
| StoreModule.forRoot(reducers, { | ||
| metaReducers, | ||
| }), | ||
| !environment.production ? StoreDevtoolsModule.instrument() : [], |
There was a problem hiding this comment.
Should this line replace lines 78-79-80?
There was a problem hiding this comment.
I have updated this line
| component.isEdit = false; | ||
| spyOn(store, 'dispatch'); | ||
| component.onSubmit(project); | ||
| expect(store.dispatch).toHaveBeenCalledWith(new actions.PostProject(project)); |
There was a problem hiding this comment.
I think a better action name would be CreateProject(project)
| spyOn(store, 'dispatch'); | ||
| component.onSubmit(project); | ||
| expect(component.savedProject.emit).toHaveBeenCalled(); | ||
| expect(store.dispatch).toHaveBeenCalledWith(new actions.PutProject(project)); |
There was a problem hiding this comment.
Let's change from PutProject to UpdateProject
|
|
||
| it('details field validity', () => { | ||
| const details = component.projectForm.controls.details; | ||
| it('description field validity', () => { |
There was a problem hiding this comment.
let's change the test name to:
it('checks if description field is valid',
I know it's not your code but let's fix this.
| @Output() cancelForm = new EventEmitter(); | ||
|
|
||
| constructor(private formBuilder: FormBuilder) { | ||
| constructor(private formBuilder: FormBuilder, private store: Store<any>) { |
There was a problem hiding this comment.
Store<any> ?
I think we have to use Store<ProjectsStore> or so
| constructor(public payload: Project) {} | ||
| } | ||
|
|
||
| export class PutProjectSuccess implements Action { |
| constructor(public payload: Project) {} | ||
| } | ||
|
|
||
| export class PutProjectFail implements Action { |
| ); | ||
|
|
||
| @Effect() | ||
| postProject$: Observable<Action> = this.actions$.pipe( |
| ); | ||
|
|
||
| @Effect() | ||
| putProject$: Observable<Action> = this.actions$.pipe( |
| isLoading: boolean; | ||
|
|
||
| constructor(private projectService: ProjectService) { | ||
| constructor(private store: Store<any>) { |
enriquezrene
approved these changes
Apr 7, 2020
|
|
||
| @Injectable() | ||
| export class ProjectEffects { | ||
| constructor(private actions$: Actions, private projectService: ProjectService, private store: Store<any>) {} |
There was a problem hiding this comment.
you're not using the store at all. Why are we injecting it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.