Add Clock In #8
Merged
Add Clock In #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
suggested changes
Mar 12, 2020
src/app/components/shared/details-fields/details-fields.component.spec.ts
Show resolved
Hide resolved
jorgecod
force-pushed
the
TimeClock-ClockIn
branch
3 times, most recently
from
f0e1d01 to
ee5a5e6
Compare
enriquezrene
suggested changes
Mar 16, 2020
src/app/components/options-sidebar/time-clock/time-clock.component.spec.ts
Show resolved
Hide resolved
| it("should set showfileds as true", () => { | ||
| const show = true; | ||
| component.showFields = show; | ||
| component.getShowFields(show); |
There was a problem hiding this comment.
It seems this function is changing showFields value. In this case, the field name should be:
setShowFields(show)
|
|
||
| getShowFields(show: boolean) { |
There was a problem hiding this comment.
definitely, the function name should be: setShowFields
enriquezrene
suggested changes
Mar 16, 2020
Comment on lines
27
to
48
| component.showFields = show; | ||
| component.setShowFields(show); |
There was a problem hiding this comment.
Why are we setting this field to true twice?
jorgecod
force-pushed
the
TimeClock-ClockIn
branch
from
2ceccec to
12a95bb
Compare
enriquezrene
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue details