Skip to content

TT-511 containerize time tracker UI #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 10, 2022
Merged

TT-511 containerize time tracker UI #798

merged 9 commits into from
Feb 10, 2022

Conversation

@mikevillarruel
Copy link
Contributor

@mikevillarruel mikevillarruel commented Jan 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 21, 2022 •
edited
Loading

Codecov Report

Merging #798 (7f0690f) into master (95d1ed3) will increase coverage by 1.84%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   95.64%   97.48%   +1.84%     
==========================================
  Files         107      107              
  Lines        2273     2427     +154     
  Branches      175      203      +28     
==========================================
+ Hits         2174     2366     +192     
+ Misses         54       23      -31     
+ Partials       45       38       -7
Impacted Files Coverage Δ
...er-management/store/customer-management.effects.ts 100.00% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
...eate-project-type/create-project-type.component.ts 96.96% <50.00%> (-3.04%) ⬇️
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...c/app/modules/time-clock/services/entry.service.ts 96.42% <75.00%> (-3.58%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 96.42% <83.33%> (+4.76%) ⬆️
...ts/projects/components/services/project.service.ts 94.11% <85.71%> (+3.20%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
src/app/modules/login/login.component.ts 95.83% <93.75%> (-4.17%) ⬇️
...ponents/details-fields/details-fields.component.ts 98.08% <96.29%> (+1.68%) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015a785...7f0690f. Read the comment docs.

OscarPallazhco
OscarPallazhco reviewed Jan 21, 2022
View reviewed changes
faustocv
faustocv reviewed Jan 27, 2022
View reviewed changes
Dockerfile Outdated

ENV USERNAME nginx

COPY nginx.conf /etc/nginx/conf.d/
Copy link
Collaborator

@faustocv faustocv Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? because the default.conf one is being copied after.

Copy link
Contributor Author

@mikevillarruel mikevillarruel Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I removed that line.

faustocv
faustocv reviewed Feb 9, 2022
View reviewed changes
Makefile Outdated

.PHONY: remove
remove: ## Delete container timetracker_ui.
docker-compose down
Copy link
Collaborator

@faustocv faustocv Feb 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikevillarruel, please add docker-compose down --volumes --remove-orphans --rmi local

Copy link
Contributor Author

@mikevillarruel mikevillarruel Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Makefile Outdated

.PHONY: login
login: ## Login in respository of docker images.
az acr login --name timetrackerdevregistry
Copy link
Collaborator

@faustocv faustocv Feb 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikevillarruel Could you specify the container registry from a parameter?

Copy link
Contributor Author

@mikevillarruel mikevillarruel Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mikevillarruel mikevillarruel force-pushed the TT-511-containerize-time-tracker-ui branch from e23d492 to 7f0690f Compare February 9, 2022 21:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

faustocv
faustocv approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@faustocv faustocv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thank you for doing this

@mikevillarruel mikevillarruel merged commit 7ce615c into master Feb 10, 2022
@mikevillarruel mikevillarruel deleted the TT-511-containerize-time-tracker-ui branch February 10, 2022 16:04
mikevillarruel added a commit that referenced this pull request Feb 10, 2022
@mikevillarruel
Revert "TT-511 containerize time tracker UI (#798)"
d24b39e 
This reverts commit 7ce615c.
@mikevillarruel mikevillarruel mentioned this pull request Feb 10, 2022
Merged
mikevillarruel added a commit that referenced this pull request Feb 10, 2022
@mikevillarruel
Revert "TT-511 containerize time tracker UI (#798)" (#809)
5da8892 
This reverts commit 7ce615c.
@mikevillarruel mikevillarruel restored the TT-511-containerize-time-tracker-ui branch February 10, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@faustocv faustocv faustocv approved these changes

@OscarPallazhco OscarPallazhco OscarPallazhco approved these changes

@MichaelAndrik MichaelAndrik MichaelAndrik approved these changes

+1 more reviewer

@MichaelGuanoluisa MichaelGuanoluisa MichaelGuanoluisa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mikevillarruel @faustocv @OscarPallazhco @MichaelGuanoluisa @MichaelAndrik