Skip to content

Conversation

scastillo-jp
Copy link
Collaborator

Validate the field description in project_types when we create a new project type.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #789 (d29a755) into master (95d1ed3) will increase coverage by 0.17%.
The diff coverage is 96.91%.

❗ Current head d29a755 differs from pull request most recent head b71100b. Consider uploading reports for the commit b71100b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   95.64%   95.82%   +0.17%     
==========================================
  Files         107      107              
  Lines        2273     2417     +144     
  Branches      175      202      +27     
==========================================
+ Hits         2174     2316     +142     
+ Misses         54       53       -1     
- Partials       45       48       +3     
Impacted Files Coverage Δ
...er-management/store/customer-management.effects.ts 100.00% <ø> (ø)
src/app/modules/time-clock/store/entry.effects.ts 96.29% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
...eate-project-type/create-project-type.component.ts 96.96% <50.00%> (-3.04%) ⬇️
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 89.28% <83.33%> (-2.39%) ⬇️
...ts/projects/components/services/project.service.ts 88.23% <85.71%> (-2.68%) ⬇️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
src/app/modules/login/login.component.ts 95.83% <93.75%> (-4.17%) ⬇️
...ponents/details-fields/details-fields.component.ts 96.17% <96.29%> (-0.23%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee69cf...b71100b. Read the comment docs.

@scastillo-jp scastillo-jp merged commit afe40ac into master Jan 12, 2022
@scastillo-jp scastillo-jp deleted the TT-504-Review-create-Projec-type branch January 12, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants