Skip to content

Conversation

@gcobena-dev
Copy link
Collaborator

Solve problem when switch from an active time entry, to another in a new project.

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #784 (b9a65b3) into master (95d1ed3) will increase coverage by 0.24%.
The diff coverage is 97.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   95.64%   95.88%   +0.24%     
==========================================
  Files         107      107              
  Lines        2273     2407     +134     
  Branches      175      195      +20     
==========================================
+ Hits         2174     2308     +134     
+ Misses         54       53       -1     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/app/modules/time-clock/store/entry.effects.ts 96.29% <ø> (ø)
src/environments/environment.ts 100.00% <ø> (ø)
...es/shared/interceptors/inject.token.interceptor.ts 87.50% <66.66%> (-12.50%) ⬇️
...p/modules/time-clock/pages/time-clock.component.ts 89.28% <83.33%> (-2.39%) ⬇️
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
src/app/modules/login/login.component.ts 95.83% <93.75%> (-4.17%) ⬇️
...ponents/details-fields/details-fields.component.ts 96.17% <96.29%> (-0.23%) ⬇️
src/app/guards/login-guard/login.guard.ts 100.00% <100.00%> (ø)
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f913333...b9a65b3. Read the comment docs.

Copy link
Contributor

@santii90ec santii90ec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@ararcos ararcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check why you are failing the tests

@gcobena-dev gcobena-dev merged commit e06f1e3 into master Dec 30, 2021
@gcobena-dev gcobena-dev deleted the TT-485-switch-time-entry branch December 30, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants