Skip to content

Conversation

@mikevillarruel
Copy link
Contributor

@mikevillarruel mikevillarruel commented Dec 23, 2021

This fix the disposition of the test column in production like follows:

Before:
image

After:
image

Copy link
Collaborator

@ararcos ararcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #783 (f1d8594) into master (95d1ed3) will increase coverage by 0.11%.
The diff coverage is 96.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   95.64%   95.76%   +0.11%     
==========================================
  Files         107      106       -1     
  Lines        2273     2335      +62     
  Branches      175      182       +7     
==========================================
+ Hits         2174     2236      +62     
+ Misses         54       53       -1     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 87.87% <80.00%> (-2.87%) ⬇️
...ponents/details-fields/details-fields.component.ts 96.17% <96.29%> (-0.23%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...anagement/pages/activities-management.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.effects.ts 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82f12b...f1d8594. Read the comment docs.

Copy link
Contributor

@santii90ec santii90ec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mikevillarruel mikevillarruel merged commit aafa221 into master Dec 23, 2021
@mikevillarruel mikevillarruel deleted the TT-471-Show-Users-list branch December 23, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants