#44 save activities using API #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enriquezrene
suggested changes
Apr 6, 2020
| { | ||
| id: '1', | ||
| name: 'Training', | ||
| description: 'It is goof for learning', |
| const activity: Activity = { | ||
| id: '1', | ||
| name: 'Training', | ||
| description: 'It is goof for learning', |
| service.baseUrl = 'activities'; | ||
|
|
||
| service.createActivity(activity).subscribe((response) => { | ||
| console.log('respun', response); |
There was a problem hiding this comment.
let's remove this console.log
| LOAD_ACTIVITIES_FAIL = '[ActivityManagement] Load Activities Fail', | ||
| CREATE_ACTIVITY = '[ActivityManagement] Create Activity', | ||
| CREATE_ACTIVITY_SUCCESS = '[ActivityManagement] Create Activity Successs', | ||
| CREATE_ACTIVITY_FAIL = '[ActivityManagement] Create Activity Fail', |
There was a problem hiding this comment.
+1 for this change, It looks way better in this way :)
Comment on lines
3
to
6
| created_at?: string; | ||
| updated_at?: string; | ||
| created_by?: string; | ||
| updated_by?: string; |
There was a problem hiding this comment.
We are not going to use these fields in the UI so I think we should not include them.
macrisguncay
force-pushed
the
44-Save-activities-using-API
branch
from
a574c4c to
a0441ff
Compare
enriquezrene
reviewed
Apr 6, 2020
| const createActivitySuccess = new CreateActivitySuccess({ | ||
| id: '1', | ||
| name: 'Training', | ||
| description: 'It is goof for learning', |
enriquezrene
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ticket was solved with ngrx