Skip to content

Conversation

ararcos
Copy link
Collaborator

@ararcos ararcos commented Nov 29, 2021

Problem
Console error "ERROR TypeError: Cannot read properties of undefined (reading 'enabled')"
image

Solution
the dark mode component file was modified to fix the console error validating when you do not have the dark mode permissions
image

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #769 (aa40938) into master (95d1ed3) will increase coverage by 0.18%.
The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   95.64%   95.82%   +0.18%     
==========================================
  Files         107      106       -1     
  Lines        2273     2325      +52     
  Branches      175      181       +6     
==========================================
+ Hits         2174     2228      +54     
+ Misses         54       52       -2     
  Partials       45       45              
Impacted Files Coverage Δ
...anagement/pages/activities-management.component.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
...nents/projects/components/store/project.effects.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a4e40...aa40938. Read the comment docs.

@ararcos ararcos merged commit 950e4c7 into master Nov 29, 2021
@ararcos ararcos deleted the TT-428-BUG-undefined-reading-enabled branch November 29, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants