Skip to content

Conversation

ararcos
Copy link
Collaborator

@ararcos ararcos commented Nov 5, 2021

Problem
The activity view needs to be read-only to retrieve this information from json.
image

Solution
Hidden the modify and create buttons inside the activity view.
image

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #766 (1c9e92c) into master (95d1ed3) will increase coverage by 0.14%.
The diff coverage is 97.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #766      +/-   ##
==========================================
+ Coverage   95.64%   95.78%   +0.14%     
==========================================
  Files         107      106       -1     
  Lines        2273     2325      +52     
  Branches      175      180       +5     
==========================================
+ Hits         2174     2227      +53     
+ Misses         54       52       -2     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...anagement/pages/activities-management.component.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 886a68b...1c9e92c. Read the comment docs.

@scastillo-jp
Copy link
Collaborator

Algunas recomendaciones:

  • cambiar el Operations a Status
  • el icono circular bajarlo un poco para que se quede alineado horizontal con el texto Active o inactive.

Screen Shot 2021-11-05 at 16 36 51

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 5, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ararcos ararcos merged commit 32796cb into master Nov 5, 2021
@ararcos ararcos deleted the TT-395-Remove-functionality-to-create-and-update-activity branch November 5, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants