Skip to content

Conversation

JosueOb
Copy link
Collaborator

@JosueOb JosueOb commented Oct 19, 2021

In this PR the default range of records has been changed from 10 to 30 reports, and the option to select a certain range of records has been added. This option has a range of 15, 30, 50, 100 or all records.

Captura de Pantalla 2021-10-19 a la(s) 12 56 57
Captura de Pantalla 2021-10-19 a la(s) 13 28 38

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #763 (85fcf9d) into master (95d1ed3) will increase coverage by 0.13%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
+ Coverage   95.64%   95.78%   +0.13%     
==========================================
  Files         107      106       -1     
  Lines        2273     2324      +51     
  Branches      175      180       +5     
==========================================
+ Hits         2174     2226      +52     
+ Misses         54       52       -2     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...anagement/pages/activities-management.component.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89cff13...85fcf9d. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosueOb JosueOb merged commit 37c28ca into master Oct 19, 2021
@JosueOb JosueOb deleted the TT-382-Changes-in-report-datatable branch October 19, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants