Skip to content

Conversation

edgardavid2015
Copy link
Contributor

Problem

When the "Add a new activity" button is clicked, it should reset the "Name" and "Description" fields.

activity-button-before

Solution

This pull request implements the reset form fields function on the "Add new activity" button.

activity-button-now

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #756 (fa9d98e) into master (95d1ed3) will increase coverage by 0.08%.
The diff coverage is 97.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   95.64%   95.72%   +0.08%     
==========================================
  Files         107      106       -1     
  Lines        2273     2316      +43     
  Branches      175      180       +5     
==========================================
+ Hits         2174     2217      +43     
+ Misses         54       52       -2     
- Partials       45       47       +2     
Impacted Files Coverage Δ
...anagement/pages/activities-management.component.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cb07b...fa9d98e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@bytesantiago bytesantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find any problems with the implementation.

@edgardavid2015 edgardavid2015 merged commit bcc97e7 into master Sep 25, 2021
@edgardavid2015 edgardavid2015 deleted the TT-354-fix-bug-activity-button branch September 25, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants