Skip to content

Conversation

@bytesantiago
Copy link
Contributor

Description

Pagination option was added to Time entries and Reports tabs, where it was not previously available. Also, test for new methods were created.

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #755 (f919ceb) into master (95d1ed3) will increase coverage by 0.13%.
The diff coverage is 97.24%.

❗ Current head f919ceb differs from pull request most recent head 5f53005. Consider uploading reports for the commit 5f53005 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   95.64%   95.77%   +0.13%     
==========================================
  Files         107      106       -1     
  Lines        2273     2322      +49     
  Branches      175      180       +5     
==========================================
+ Hits         2174     2224      +50     
+ Misses         54       52       -2     
- Partials       45       46       +1     
Impacted Files Coverage Δ
...anagement/pages/activities-management.component.ts 100.00% <ø> (ø)
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
src/environments/environment.ts 100.00% <ø> (ø)
...project-list-hover/project-list-hover.component.ts 90.90% <93.33%> (+0.16%) ⬆️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...ponents/details-fields/details-fields.component.ts 96.15% <96.00%> (-0.25%) ⬇️
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...ts/projects/components/services/project.service.ts 91.66% <100.00%> (+0.75%) ⬆️
...nents/projects/components/store/project.actions.ts 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b50b6c...5f53005. Read the comment docs.

@bytesantiago bytesantiago force-pushed the TT-344-add-pagination-where-feature-is-not-available branch from cb3e330 to 865a6d3 Compare September 21, 2021 17:39
@EdansRocks

This comment has been minimized.

@EdansRocks

This comment has been minimized.

@JosueOb

This comment has been minimized.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@josepato87 josepato87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosueOb
Copy link
Collaborator

JosueOb commented Sep 29, 2021

Hi Santiago, I report that in the time entry section when you select a month that has no entries and then go back to a month that has entries, the pagination is not displayed.
Captura de Pantalla 2021-09-28 a la(s) 19 25 25
Captura de Pantalla 2021-09-28 a la(s) 19 26 29

Captura de Pantalla 2021-09-28 a la(s) 19 27 10

@bytesantiago bytesantiago merged commit c1f523f into master Sep 29, 2021
@bytesantiago bytesantiago deleted the TT-344-add-pagination-where-feature-is-not-available branch September 29, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants