Skip to content

Conversation

edgardavid2015
Copy link
Contributor

Problem

When the Activities section is selected, the option to create a new activity or to edit an activity is always present:

activities-section-before

Solution

In this pull request, the form to add or edit activity is hidden by default.

A button to "Add a new activity" has been created. When this button is clicked, the form to add a new activity appears:

new-button

The same occurs when the edit activity button is clicked:

edit-button-now

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #754 (3dbbbad) into master (95d1ed3) will increase coverage by 0.11%.
The diff coverage is 97.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   95.64%   95.75%   +0.11%     
==========================================
  Files         107      107              
  Lines        2273     2286      +13     
  Branches      175      176       +1     
==========================================
+ Hits         2174     2189      +15     
+ Misses         54       52       -2     
  Partials       45       45              
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...omponents/activity-list/activity-list.component.ts 100.00% <100.00%> (ø)
...nents/create-activity/create-activity.component.ts 100.00% <100.00%> (ø)
...anagement/pages/activities-management.component.ts 100.00% <100.00%> (ø)
...time-entries-table/time-entries-table.component.ts 80.00% <100.00%> (+2.22%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 100.00% <100.00%> (+9.52%) ⬆️
...p/modules/shared/components/user/user.component.ts 100.00% <100.00%> (ø)
src/environments/enum.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824744e...3dbbbad. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgardavid2015 edgardavid2015 merged commit 2461f61 into master Sep 21, 2021
@edgardavid2015 edgardavid2015 deleted the TT-337-New-activity-button branch September 21, 2021 16:21
bytesantiago added a commit that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants