Skip to content

Conversation

@edgardavid2015
Copy link
Contributor

Problem

The current sidebar of the time tracker application is OK, it's working and has no functionality errors. But this sidebar could have a better design that enhances the user experience.

current_sidebar

Solution

In this pull request, the sidebar has a modern design, with new icons, new colors, and new functionality.

new_sidebar

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #750 (a0bb3cc) into master (95d1ed3) will increase coverage by 0.08%.
The diff coverage is 96.87%.

❗ Current head a0bb3cc differs from pull request most recent head 1b36bd0. Consider uploading reports for the commit 1b36bd0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   95.64%   95.72%   +0.08%     
==========================================
  Files         107      107              
  Lines        2273     2271       -2     
  Branches      175      175              
==========================================
  Hits         2174     2174              
+ Misses         54       52       -2     
  Partials       45       45              
Impacted Files Coverage Δ
...omponents/customer-list/customer-list.component.ts 98.52% <ø> (-0.03%) ⬇️
...shared/components/dark-mode/dark-mode.component.ts 95.45% <95.45%> (ø)
...les/shared/components/sidebar/sidebar.component.ts 100.00% <100.00%> (+9.52%) ⬆️
...p/modules/shared/components/user/user.component.ts 100.00% <100.00%> (ø)
src/environments/enum.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777051e...1b36bd0. Read the comment docs.

@edgardavid2015 edgardavid2015 changed the title Tt 331 redesign of the sidebar TT-331 redesign of the sidebar Sep 11, 2021
Copy link
Collaborator

@JosueOb JosueOb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Edgar, I have checked your changes and everything works fine but I see that you are not using the color palette set for the project and you are not considering the changes for the dark mode.

@edgardavid2015 edgardavid2015 force-pushed the TT-331-Redesign-of-the-sidebar branch from 71b0933 to 7f947c9 Compare September 14, 2021 00:40
@JosueOb JosueOb self-requested a review September 14, 2021 06:38
Copy link
Collaborator

@JosueOb JosueOb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished reviewing the changes made and I have some suggestions, the first one is about the icons, I see that some SVG icons are still kept in the assets directory, I think those icons that are not used should be removed, and the position of the icon to show or hide the sidebar does not keep its initial position.

@JosueOb JosueOb self-requested a review September 14, 2021 06:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgardavid2015 edgardavid2015 merged commit eec5cf4 into master Sep 14, 2021
@edgardavid2015 edgardavid2015 deleted the TT-331-Redesign-of-the-sidebar branch September 14, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants