-
Notifications
You must be signed in to change notification settings - Fork 1
TT-331 redesign of the sidebar #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 95.64% 95.72% +0.08%
==========================================
Files 107 107
Lines 2273 2271 -2
Branches 175 175
==========================================
Hits 2174 2174
+ Misses 54 52 -2
Partials 45 45
Continue to review full report at Codecov.
|
JosueOb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Edgar, I have checked your changes and everything works fine but I see that you are not using the color palette set for the project and you are not considering the changes for the dark mode.
resolve merge conflicts
resolving merge conflicts
resolving merge conflicts
resolving merge conflicts
71b0933 to
7f947c9
Compare
src/app/modules/shared/components/sidebar/sidebar.component.scss
Outdated
Show resolved
Hide resolved
JosueOb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished reviewing the changes made and I have some suggestions, the first one is about the icons, I see that some SVG icons are still kept in the assets directory, I think those icons that are not used should be removed, and the position of the icon to show or hide the sidebar does not keep its initial position.
|
Kudos, SonarCloud Quality Gate passed!
|








Problem
The current sidebar of the time tracker application is OK, it's working and has no functionality errors. But this sidebar could have a better design that enhances the user experience.
Solution
In this pull request, the sidebar has a modern design, with new icons, new colors, and new functionality.