Skip to content

Conversation

bytesantiago
Copy link
Contributor

With the modification of the lines of code of this pull request, each new time entry created from the "Time Entries" menu will have the following hour format established: "HH:mm:ss", where ss will always be set to 00 to avoid conflicts with inexistent time overlaps.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #744 (2044930) into master (2b16e33) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2044930 differs from pull request most recent head 30ad48e. Consider uploading reports for the commit 30ad48e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   95.54%   95.55%           
=======================================
  Files         106      106           
  Lines        2247     2250    +3     
  Branches      169      169           
=======================================
+ Hits         2147     2150    +3     
  Misses         57       57           
  Partials       43       43           
Impacted Files Coverage Δ
...time-entries-table/time-entries-table.component.ts 77.77% <ø> (ø)
...les/shared/components/sidebar/sidebar.component.ts 90.47% <ø> (ø)
...e-toggle-general/feature-toggle-general.service.ts 100.00% <ø> (ø)
.../feature-toggles/feature-toggle-manager.service.ts 100.00% <ø> (ø)
...dules/time-entries/pages/time-entries.component.ts 88.99% <100.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5bf7ee...30ad48e. Read the comment docs.

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @DrFreud1, you can check the suggestions I made, if you consider, implement it

@bytesantiago
Copy link
Contributor Author

Check here first if the current date has milliseconds at 0, then update the test if necessary.

Thank you for your review Sandro, with the next commit, this is fixed

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Review this functionality and all works perfectly, Good Job @DrFreud1 💥, Only my last suggestion at level code, if you consider implement it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bytesantiago bytesantiago merged commit a741fb6 into master Sep 3, 2021
@bytesantiago bytesantiago deleted the TT-328-Standardize-the-seconds-and-milliseconds-in-Time-entries branch September 3, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants