-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-328 when editing/creating entries set seconds to 0 #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TT-328 when editing/creating entries set seconds to 0 #744
Conversation
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 95.54% 95.55%
=======================================
Files 106 106
Lines 2247 2250 +3
Branches 169 169
=======================================
+ Hits 2147 2150 +3
Misses 57 57
Partials 43 43
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job @DrFreud1, you can check the suggestions I made, if you consider, implement it
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
Thank you for your review Sandro, with the next commit, this is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Review this functionality and all works perfectly, Good Job @DrFreud1 💥, Only my last suggestion at level code, if you consider implement it.
Kudos, SonarCloud Quality Gate passed!
|
With the modification of the lines of code of this pull request, each new time entry created from the "Time Entries" menu will have the following hour format established: "HH:mm:ss", where ss will always be set to 00 to avoid conflicts with inexistent time overlaps.