-
Notifications
You must be signed in to change notification settings - Fork 1
Tt 318 improve column visibility section #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tt 318 improve column visibility section #740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
+ Coverage 95.24% 95.57% +0.33%
==========================================
Files 106 106
Lines 2206 2258 +52
Branches 169 169
==========================================
+ Hits 2101 2158 +57
+ Misses 61 57 -4
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
7e303dd
to
a5aad06
Compare
I have tested the last two commits and the Excel and CSV options show the contents of the selected columns. Well done Edgar. |
ec87445
to
8539823
Compare
Kudos, SonarCloud Quality Gate passed!
|
Problem
In the Reports section, when we select the "Column visibility" button, this button shows a button row where each button represents a column name in the table.
This is working fine, but there is no notable difference between the selected buttons and no selected buttons inside this button row.
Moreover, when there is a reduction in the screen size, the "Column visibility" button is not showing anything.
Solution
In this pull request when we select the "Column visibility" button, we can see a clear difference between the selected buttons and no selected buttons by their color.
Also, when the screen size changes, the "Column visibility" button will display the button row as it normally does, adding a scroll in the y-axis.
Note:
As a bonus, the print button functionality was improved, now it only prints the columns that are displayed in the table.