Skip to content

Conversation

edgardavid2015
Copy link
Contributor

@edgardavid2015 edgardavid2015 commented Aug 26, 2021

Problem

In the Reports section, when we select the "Column visibility" button, this button shows a button row where each button represents a column name in the table.
This is working fine, but there is no notable difference between the selected buttons and no selected buttons inside this button row.

column_visibility_before

Moreover, when there is a reduction in the screen size, the "Column visibility" button is not showing anything.

column_visibility_screen_size_reduction

Solution

In this pull request when we select the "Column visibility" button, we can see a clear difference between the selected buttons and no selected buttons by their color.

column_visibility_after

Also, when the screen size changes, the "Column visibility" button will display the button row as it normally does, adding a scroll in the y-axis.

column_visibility_screen_size_after

Note:
As a bonus, the print button functionality was improved, now it only prints the columns that are displayed in the table.

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #740 (6e6a1b8) into master (9a68415) will increase coverage by 0.33%.
The diff coverage is 96.42%.

❗ Current head 6e6a1b8 differs from pull request most recent head 8539823. Consider uploading reports for the commit 8539823 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #740      +/-   ##
==========================================
+ Coverage   95.24%   95.57%   +0.33%     
==========================================
  Files         106      106              
  Lines        2206     2258      +52     
  Branches      169      169              
==========================================
+ Hits         2101     2158      +57     
+ Misses         61       57       -4     
+ Partials       44       43       -1     
Impacted Files Coverage Δ
src/app/app-routing.module.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 77.77% <ø> (+14.14%) ⬆️
...les/shared/components/sidebar/sidebar.component.ts 90.90% <ø> (-1.69%) ⬇️
.../components/entry-fields/entry-fields.component.ts 97.18% <ø> (-0.04%) ⬇️
.../components/technologies/technologies.component.ts 85.18% <83.33%> (+0.81%) ⬆️
...ponents/details-fields/details-fields.component.ts 96.40% <100.00%> (+0.16%) ⬆️
...c/app/modules/shared/utils/project-storage.util.ts 100.00% <100.00%> (ø)
...project-list-hover/project-list-hover.component.ts 90.74% <100.00%> (+0.35%) ⬆️
...-entries/components/calendar/calendar.component.ts 95.38% <100.00%> (+0.22%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.67% <100.00%> (+0.67%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf26092...8539823. Read the comment docs.

@edgardavid2015 edgardavid2015 force-pushed the TT-318-Improve-column-visibility-section branch from 7e303dd to a5aad06 Compare August 27, 2021 00:01
@JosueOb
Copy link
Collaborator

JosueOb commented Aug 30, 2021

I have tested the last two commits and the Excel and CSV options show the contents of the selected columns. Well done Edgar.

@edgardavid2015 edgardavid2015 force-pushed the TT-318-Improve-column-visibility-section branch from ec87445 to 8539823 Compare August 30, 2021 17:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgardavid2015 edgardavid2015 merged commit 36eb2b9 into master Aug 30, 2021
@edgardavid2015 edgardavid2015 deleted the TT-318-Improve-column-visibility-section branch August 30, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants