Skip to content

Conversation

edgardavid2015
Copy link
Contributor

Problem

  1. In the Users section, there is a table with the following columns: User email, Names, and Groups. This is not so useful, because the names of the users should go first:

Captura de Pantalla 2021-08-23 a la(s) 20 16 20

  1. In the Reports section, the Duration column is not showing all its letters, it seems like there is a problem with the name of the column:

Captura de Pantalla 2021-08-23 a la(s) 20 22 47

Solution

  1. A switch between the Email column and the Names column has been made to improve the user experience:

Captura de Pantalla 2021-08-23 a la(s) 20 16 08

  1. The Duration column now is showing all its letters:

Captura de Pantalla 2021-08-23 a la(s) 20 31 47

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #737 (408a318) into master (9a68415) will increase coverage by 0.17%.
The diff coverage is 96.19%.

❗ Current head 408a318 differs from pull request most recent head ac719c7. Consider uploading reports for the commit ac719c7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   95.24%   95.41%   +0.17%     
==========================================
  Files         106      107       +1     
  Lines        2206     2268      +62     
  Branches      169      171       +2     
==========================================
+ Hits         2101     2164      +63     
  Misses         61       61              
+ Partials       44       43       -1     
Impacted Files Coverage Δ
.../components/entry-fields/entry-fields.component.ts 97.18% <ø> (-0.04%) ⬇️
.../components/technologies/technologies.component.ts 85.18% <83.33%> (+0.81%) ⬆️
...ponents/details-fields/details-fields.component.ts 96.40% <100.00%> (+0.16%) ⬆️
...c/app/modules/shared/utils/project-storage.util.ts 100.00% <100.00%> (ø)
...project-list-hover/project-list-hover.component.ts 90.74% <100.00%> (+0.35%) ⬆️
...-entries/components/calendar/calendar.component.ts 95.23% <100.00%> (+0.07%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.11% <100.00%> (+0.11%) ⬆️
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb65c3...ac719c7. Read the comment docs.

@edgardavid2015 edgardavid2015 merged commit dd92ce4 into master Aug 24, 2021
@edgardavid2015 edgardavid2015 deleted the TT-320-Improve-tables-customers-users branch August 24, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants