Skip to content

Conversation

edgardavid2015
Copy link
Contributor

Problem

As Time-tracker is working now, there are a few problems with the calendar feature in the Time entries section.

The problems are:

1.- In the month view, when we scroll down, the days of the week disappear:

Problema_cabeceras_mes

2.- The same problem described above occurs in the week view section:

Problema_headers_weekview

3.- Also, in the month view, when we decrease the size of the screen, the time entries are not responsive:

Problema_mes_responsive

Solution

For the problems listed before, the solutions are:

1.- In this pull request, no matter how deep we scroll in the calendar, the days of the week stay fixed as a header:

Captura de Pantalla 2021-08-22 a la(s) 22 46 18

2.- The solution in the previous point also applies to the week section:

Captura de Pantalla 2021-08-22 a la(s) 22 52 36

3.- In terms of the time entries, when there is a reduction in the screen size, time entries decrease its size as well:

Captura de Pantalla 2021-08-22 a la(s) 22 58 44

Note:
As a bonus in this pull request, Monday became the first day of the week instead of Sunday.

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #732 (38310d8) into master (9a68415) will increase coverage by 0.17%.
The diff coverage is 96.19%.

❗ Current head 38310d8 differs from pull request most recent head 08ef05d. Consider uploading reports for the commit 08ef05d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
+ Coverage   95.24%   95.41%   +0.17%     
==========================================
  Files         106      107       +1     
  Lines        2206     2268      +62     
  Branches      169      171       +2     
==========================================
+ Hits         2101     2164      +63     
  Misses         61       61              
+ Partials       44       43       -1     
Impacted Files Coverage Δ
.../components/entry-fields/entry-fields.component.ts 97.18% <ø> (-0.04%) ⬇️
.../components/technologies/technologies.component.ts 85.18% <83.33%> (+0.81%) ⬆️
...ponents/details-fields/details-fields.component.ts 96.40% <100.00%> (+0.16%) ⬆️
...c/app/modules/shared/utils/project-storage.util.ts 100.00% <100.00%> (ø)
...project-list-hover/project-list-hover.component.ts 90.74% <100.00%> (+0.35%) ⬆️
...-entries/components/calendar/calendar.component.ts 95.23% <100.00%> (+0.07%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.11% <100.00%> (+0.11%) ⬆️
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f891b4b...08ef05d. Read the comment docs.

@edgardavid2015 edgardavid2015 force-pushed the TT-315-Fixed-Headers-weekdays branch from d33fb23 to 0161b51 Compare August 23, 2021 16:20
@edgardavid2015 edgardavid2015 force-pushed the TT-315-Fixed-Headers-weekdays branch from 0161b51 to 08ef05d Compare August 23, 2021 16:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgardavid2015 edgardavid2015 merged commit ebb65c3 into master Aug 23, 2021
@edgardavid2015 edgardavid2015 deleted the TT-315-Fixed-Headers-weekdays branch August 23, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants