-
Notifications
You must be signed in to change notification settings - Fork 1
TT-304 Handle message: the data could not be load #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TT-304 Handle message: the data could not be load #728
Conversation
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 95.24% 95.33% +0.09%
==========================================
Files 106 106
Lines 2206 2252 +46
Branches 169 170 +1
==========================================
+ Hits 2101 2147 +46
Misses 61 61
Partials 44 44
Continue to review full report at Codecov.
|
cc9bb63
to
f805cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Edgar 💥 , only a few suggestions, if you consider implement it.
cbe30d8
to
e3bf5c5
Compare
a6c2392
to
9bff779
Compare
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have any observations about the last changes. Besides, the functionality is working fine for me.
Problem
In the time-entries section, when there is no data, the message "The data could not be load" is displayed.

Solution
When there is no data, instead of the message "The data could not be load", the message "No data available in table" should be displayed in the table section. That is the purpose of this pull request.
