Skip to content

Conversation

edgardavid2015
Copy link
Contributor

Problem

In the time-entries section, when there is no data, the message "The data could not be load" is displayed.
Error-dataMessage

Solution

When there is no data, instead of the message "The data could not be load", the message "No data available in table" should be displayed in the table section. That is the purpose of this pull request.
solution-errorMessage

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #728 (8ae5490) into master (9a68415) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 8ae5490 differs from pull request most recent head 9bff779. Consider uploading reports for the commit 9bff779 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
+ Coverage   95.24%   95.33%   +0.09%     
==========================================
  Files         106      106              
  Lines        2206     2252      +46     
  Branches      169      170       +1     
==========================================
+ Hits         2101     2147      +46     
  Misses         61       61              
  Partials       44       44              
Impacted Files Coverage Δ
...dules/time-entries/pages/time-entries.component.ts 88.11% <100.00%> (+0.11%) ⬆️
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.reducers.ts 96.55% <100.00%> (+1.81%) ⬆️
src/environments/environment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe13c1...9bff779. Read the comment docs.

@edgardavid2015 edgardavid2015 force-pushed the TT-304-Handle-message-the-data-could-not-be-load branch from cc9bb63 to f805cc6 Compare August 19, 2021 16:55
Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Edgar 💥 , only a few suggestions, if you consider implement it.

@edgardavid2015 edgardavid2015 force-pushed the TT-304-Handle-message-the-data-could-not-be-load branch from cbe30d8 to e3bf5c5 Compare August 20, 2021 01:21
@edgardavid2015 edgardavid2015 changed the title Tt 304 handle message the data could not be load TT-304 Handle message: the data could not be load Aug 20, 2021
@edgardavid2015 edgardavid2015 force-pushed the TT-304-Handle-message-the-data-could-not-be-load branch from a6c2392 to 9bff779 Compare August 21, 2021 02:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@bytesantiago bytesantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have any observations about the last changes. Besides, the functionality is working fine for me.

@edgardavid2015 edgardavid2015 merged commit 6cad459 into master Aug 22, 2021
@edgardavid2015 edgardavid2015 deleted the TT-304-Handle-message-the-data-could-not-be-load branch August 22, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants