Skip to content

Conversation

ridouku
Copy link
Contributor

@ridouku ridouku commented Aug 18, 2021

Observation

Actually the responsive in time entries is not working
Screen Shot 2021-08-17 at 17 13 10
There is a mistake with name Previus, and the titles aren’t responsive

Screen Shot 2021-08-17 at 17 13 10

Solution

The scss of calendar component was changed to truncate the tittle text and fix time entries responsive, was changed Previus to Previous.

Screen Shot 2021-08-17 at 17 13 10

Screen Shot 2021-08-17 at 17 12 42

Screen Shot 2021-08-18 at 10 21 23

…f github.com:ioet/time-tracker-ui into TT-312-Calendar-the-section-titles-is-not-responsive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #727 (f2729cf) into master (9a68415) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head f2729cf differs from pull request most recent head f05546e. Consider uploading reports for the commit f05546e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   95.24%   95.33%   +0.09%     
==========================================
  Files         106      106              
  Lines        2206     2251      +45     
  Branches      169      170       +1     
==========================================
+ Hits         2101     2146      +45     
  Misses         61       61              
  Partials       44       44              
Impacted Files Coverage Δ
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.reducers.ts 96.55% <100.00%> (+1.81%) ⬆️
src/environments/environment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96d64b...f05546e. Read the comment docs.

Copy link
Contributor

@bytesantiago bytesantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I tested, the functionality is working fine and I do not see any problems with the implementation. Good job @ridouku !

@ridouku ridouku merged commit 347bb6e into master Aug 19, 2021
@ridouku ridouku deleted the TT-312-Calendar-the-section-titles-is-not-responsive branch August 19, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants