Skip to content

Conversation

@jcalarcon98
Copy link
Contributor

@jcalarcon98 jcalarcon98 commented Aug 12, 2021

Description

Currently, the backend verifies the user has the admin role to visualize information in the reports section.
However, the Time Tracker UI, in the Users section, only adds the user to the group of time-tracker-admin but does not add the role.

Solution

With this PR each time a user is added to the admin group, the admin role is also added, and if the user is removed, the admin role is removed as well.

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #720 (736099a) into master (9a68415) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 736099a differs from pull request most recent head ef52527. Consider uploading reports for the commit ef52527 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
+ Coverage   95.24%   95.33%   +0.09%     
==========================================
  Files         106      106              
  Lines        2206     2251      +45     
  Branches      169      170       +1     
==========================================
+ Hits         2101     2146      +45     
  Misses         61       61              
  Partials       44       44              
Impacted Files Coverage Δ
...sers/components/users-list/users-list.component.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.actions.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.effects.ts 100.00% <100.00%> (ø)
src/app/modules/users/store/user.reducers.ts 96.55% <100.00%> (+1.81%) ⬆️
src/environments/environment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b2053...ef52527. Read the comment docs.

@edgardavid2015 edgardavid2015 changed the title fix: TT-310 Reports does not work with groups fixed fix: TT-310 Reports do not work with groups fixed Aug 12, 2021
Copy link
Contributor

@edgardavid2015 edgardavid2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I watched how @jcalarcon98 worked on the development of this solution. Everything looks great to me.

@jcalarcon98 jcalarcon98 force-pushed the TT-310-Reports-does-not-work-with-groups branch 2 times, most recently from 7e4b61f to aad74a5 Compare August 16, 2021 17:48
@jcalarcon98 jcalarcon98 force-pushed the TT-310-Reports-does-not-work-with-groups branch from aad74a5 to ef52527 Compare August 17, 2021 16:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jcalarcon98 jcalarcon98 merged commit e54d1ad into master Aug 17, 2021
@jcalarcon98 jcalarcon98 deleted the TT-310-Reports-does-not-work-with-groups branch August 17, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants