-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-310 Reports do not work with groups fixed #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #720 +/- ##
==========================================
+ Coverage 95.24% 95.33% +0.09%
==========================================
Files 106 106
Lines 2206 2251 +45
Branches 169 170 +1
==========================================
+ Hits 2101 2146 +45
Misses 61 61
Partials 44 44
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I watched how @jcalarcon98 worked on the development of this solution. Everything looks great to me.
7e4b61f to
aad74a5
Compare
src/app/modules/users/components/users-list/users-list.component.html
Outdated
Show resolved
Hide resolved
aad74a5 to
ef52527
Compare
|
Kudos, SonarCloud Quality Gate passed!
|








Description
Currently, the backend verifies the user has the
adminrole to visualize information in the reports section.However, the Time Tracker UI, in the Users section, only adds the user to the group of
time-tracker-adminbut does not add the role.Solution
With this PR each time a user is added to the admin group, the admin role is also added, and if the user is removed, the admin role is removed as well.