Skip to content

Conversation

@PieritoAlva95
Copy link
Contributor

Description of the problem

Currently in the part of the calendar that is merged into production, when clicking on the week or day view, these views show entries from 12 AM and users have to scroll to the current time or task they are working on.
image

image

Solution

This PR solves this problem by making the week and day views display at the current time or to be more specific to show the view in the red horizontal bar.
image
image

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #715 (a644e52) into master (13de42e) will increase coverage by 2.10%.
The diff coverage is 96.48%.

❗ Current head a644e52 differs from pull request most recent head c3f2ad4. Consider uploading reports for the commit c3f2ad4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   93.09%   95.19%   +2.10%     
==========================================
  Files          85      106      +21     
  Lines        1564     2186     +622     
  Branches      107      167      +60     
==========================================
+ Hits         1456     2081     +625     
+ Misses         67       61       -6     
- Partials       41       44       +3     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
...toggles/filters/feature-filter-provider.service.ts 80.00% <62.50%> (+2.22%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.66% <93.33%> (+12.45%) ⬆️
...-entries/components/calendar/calendar.component.ts 94.73% <94.73%> (ø)
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c17b3...c3f2ad4. Read the comment docs.

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @PieritoAlva95 💥 , please consider my suggestions.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@edgardavid2015 edgardavid2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @PieritoAlva95, this new feature works fine.

@PieritoAlva95 PieritoAlva95 merged commit 8fa17b2 into master Aug 10, 2021
@PieritoAlva95 PieritoAlva95 deleted the TT-296-navigate-to-active-entry branch August 10, 2021 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants