Skip to content

Conversation

bytesantiago
Copy link
Contributor

Problem

In the UI, when archiving or unarchiving an activity, all the content of it was shown on the UI, as shown in the picture below. This was not visually comfortable for the user, and thus the content does not need to appear when performing the actions mentioned at the beginning.

Solution

The variables which were causing this visual problem were removed and therefore, the tests needed for those variables are no longer necessary and were also removed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #713 (e9d751b) into master (13de42e) will increase coverage by 2.21%.
The diff coverage is 96.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   93.09%   95.31%   +2.21%     
==========================================
  Files          85      106      +21     
  Lines        1564     2175     +611     
  Branches      107      164      +57     
==========================================
+ Hits         1456     2073     +617     
+ Misses         67       61       -6     
  Partials       41       41              
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
...toggles/filters/feature-filter-provider.service.ts 80.00% <62.50%> (+2.22%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.66% <93.33%> (+12.45%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.76% <95.52%> (+8.58%) ⬆️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9482ef...e9d751b. Read the comment docs.

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @DrFreud1 🥇

@bytesantiago bytesantiago requested a review from ridouku August 4, 2021 21:06
@bytesantiago bytesantiago merged commit d0c17b3 into master Aug 5, 2021
@bytesantiago bytesantiago deleted the TT-299-Activities-when-active-inactive-an-activity-not-display-information-in-name-description branch August 5, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants