Skip to content

Conversation

@bytesantiago
Copy link
Contributor

When archiving/activating an activity, the data of that entry is shown on the interface which is not desirable. To fix the problem, certain variables were changed in the state machine of angular.

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #710 (96d5bbd) into master (13de42e) will increase coverage by 2.40%.
The diff coverage is 97.08%.

❗ Current head 96d5bbd differs from pull request most recent head 86f010d. Consider uploading reports for the commit 86f010d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   93.09%   95.50%   +2.40%     
==========================================
  Files          85      105      +20     
  Lines        1564     2178     +614     
  Branches      107      166      +59     
==========================================
+ Hits         1456     2080     +624     
+ Misses         67       56      -11     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...toggles/filters/feature-filter-provider.service.ts 93.33% <87.50%> (+15.55%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.77% <93.75%> (+12.56%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.76% <95.52%> (+8.58%) ⬆️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d12ce95...86f010d. Read the comment docs.

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @DrFreud1 💥.

I have reviewed the changes made and I think the following property:

activityIdToEdit: undefined

If it has a value of undefined, it is technically no longer required, so it would be best to remove it.

I also noticed that some comments have been left in the code, these should not be added. Please review my suggestions and if you feel it is necessary you can implement it.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bytesantiago bytesantiago deleted the TT-299-Activities-when-active-inactive-an-activity-do-not-display-information-in-name-description branch July 30, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants