-
Notifications
You must be signed in to change notification settings - Fork 1
Tt 289 cannot edit the date of an entry #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 93.09% 95.50% +2.40%
==========================================
Files 85 105 +20
Lines 1564 2178 +614
Branches 107 166 +59
==========================================
+ Hits 1456 2080 +624
+ Misses 67 56 -11
- Partials 41 42 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job 💥 Santiago, please check my comments and if you consider them necessary you can apply them.
src/app/modules/shared/components/details-fields/details-fields.component.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
This reverts commit d12ce95.








An additional comparison was added in order to allow the user to change the date of an entry. Because of that, certain tests were removed because they were no longer relevant. However, the method that was modified has other tests relevant for what it actually does.
To summarize, one method was modified, two tests were removed because no longer needed.