Skip to content

Conversation

@bytesantiago
Copy link
Contributor

@bytesantiago bytesantiago commented Jul 23, 2021

An additional comparison was added in order to allow the user to change the date of an entry. Because of that, certain tests were removed because they were no longer relevant. However, the method that was modified has other tests relevant for what it actually does.

To summarize, one method was modified, two tests were removed because no longer needed.

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #708 (981cfb8) into master (13de42e) will increase coverage by 2.40%.
The diff coverage is 97.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   93.09%   95.50%   +2.40%     
==========================================
  Files          85      105      +20     
  Lines        1564     2178     +614     
  Branches      107      166      +59     
==========================================
+ Hits         1456     2080     +624     
+ Misses         67       56      -11     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...toggles/filters/feature-filter-provider.service.ts 93.33% <87.50%> (+15.55%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.00% <88.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.77% <93.75%> (+12.56%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.76% <95.52%> (+8.58%) ⬆️
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56bb4e0...981cfb8. Read the comment docs.

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 💥 Santiago, please check my comments and if you consider them necessary you can apply them.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bytesantiago bytesantiago merged commit d12ce95 into master Jul 23, 2021
@bytesantiago bytesantiago deleted the TT-289-Cannot-edit-the-date-of-an-entry branch July 23, 2021 19:42
@bytesantiago bytesantiago restored the TT-289-Cannot-edit-the-date-of-an-entry branch July 23, 2021 19:53
bytesantiago added a commit that referenced this pull request Jul 23, 2021
@bytesantiago bytesantiago deleted the TT-289-Cannot-edit-the-date-of-an-entry branch July 23, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants