Skip to content

Tt 289 cannot edit the date of an entry #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Tt 289 cannot edit the date of an entry #707

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
438279f
fix: TT-289 added an extra comparison to make sure the update date is…
bytesantiago Jul 20, 2021
04aa357
fix: TT-289 remove non-relevant anymore test cases, after fist changes
bytesantiago Jul 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: TT-289 added an extra comparison to make sure the update date is… 
… being saved
  • Loading branch information
@bytesantiago
bytesantiago committed Jul 20, 2021
commit 438279f209012664f8ffcdeb053f6def38f49a6c
2 changes: 1 addition & 1 deletion src/app/modules/shared/components/details-fields/details-fields.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export class DetailsFieldsComponent implements OnChanges, OnInit {
const updatedDate = new Date(`${entryFormDate}T${updatedHour.trim()}`).toISOString();
const initialDate = get(this.entryToEdit, date, updatedDate);
const initialHour = formatDate(get(this.entryToEdit, date, updatedDate), 'HH:mm', 'en');
const dateHasNotChanged = updatedHour === initialHour;
const dateHasNotChanged = (initialDate === updatedDate) && (updatedHour === initialHour);
const result = dateHasNotChanged ? initialDate : updatedDate;
return result;
}
Expand Down