Skip to content

Conversation

@kevinjlope
Copy link
Contributor

Problem
Currently, there are some unnecessary feature toggles in the UI.
Solution
Removed feature toggles and the unit testing associated.

@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #706 (7129732) into master (13de42e) will increase coverage by 2.30%.
The diff coverage is 96.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   93.09%   95.40%   +2.30%     
==========================================
  Files          85      106      +21     
  Lines        1564     2175     +611     
  Branches      107      164      +57     
==========================================
+ Hits         1456     2075     +619     
+ Misses         67       59       -8     
  Partials       41       41              
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
...toggles/filters/feature-filter-provider.service.ts 80.00% <62.50%> (+2.22%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.66% <93.33%> (+12.45%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.76% <95.52%> (+8.58%) ⬆️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a3fa4...7129732. Read the comment docs.

@kevinjlope kevinjlope force-pushed the TT-295-Remove-Feaure-Toggle branch from 1455663 to 91fe4e5 Compare July 22, 2021 16:49
Copy link
Collaborator

@JosueOb JosueOb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already tried the local project and had no problem.

Copy link
Contributor

@PieritoAlva95 PieritoAlva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good work, keep up the good work 👍🏼 💯 🥇

Copy link
Contributor

@jase156 jase156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job Kevin and Edgar

@edgardavid2015 edgardavid2015 force-pushed the TT-295-Remove-Feaure-Toggle branch from a7d6c80 to 1ee3100 Compare August 2, 2021 21:20
@edgardavid2015 edgardavid2015 force-pushed the TT-295-Remove-Feaure-Toggle branch from 1ee3100 to 7129732 Compare August 3, 2021 17:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgardavid2015 edgardavid2015 merged commit f9482ef into master Aug 3, 2021
@edgardavid2015 edgardavid2015 deleted the TT-295-Remove-Feaure-Toggle branch August 3, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants