-
Notifications
You must be signed in to change notification settings - Fork 1
refactor: TT-295 removal unnecessary feature toggles #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #706 +/- ##
==========================================
+ Coverage 93.09% 95.40% +2.30%
==========================================
Files 85 106 +21
Lines 1564 2175 +611
Branches 107 164 +57
==========================================
+ Hits 1456 2075 +619
+ Misses 67 59 -8
Partials 41 41
Continue to review full report at Codecov.
|
1455663 to
91fe4e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already tried the local project and had no problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work, keep up the good work 👍🏼 💯 🥇
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Show resolved
Hide resolved
src/app/modules/time-clock/components/entry-fields/entry-fields.component.ts
Show resolved
Hide resolved
...modules/shared/feature-toggles/feature-toggle-general/feature-toggle-general.service.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job Kevin and Edgar
a7d6c80 to
1ee3100
Compare
1ee3100 to
7129732
Compare
|
Kudos, SonarCloud Quality Gate passed!
|








Problem
Currently, there are some unnecessary feature toggles in the UI.
Solution
Removed feature toggles and the unit testing associated.