fix: TT-290 added a new component (dropdown), and change the style the buttons associeted #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjlope
requested review from
PieritoAlva95,
jase156,
jcalarcon98 and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #705 +/- ##
==========================================
+ Coverage 93.09% 95.51% +2.42%
==========================================
Files 85 106 +21
Lines 1564 2187 +623
Branches 107 167 +60
==========================================
+ Hits 1456 2089 +633
+ Misses 67 56 -11
- Partials 41 42 +1
Continue to review full report at Codecov.
|
kevinjlope
force-pushed
the
TT-290-Improve-status-active-inactive
branch
from
f94c2c7 to
11d646d
Compare
jcalarcon98
reviewed
Jul 23, 2021
Contributor
jcalarcon98
left a comment
jcalarcon98
left a comment
There was a problem hiding this comment.
Excellent work Kevin 💥 , please review the suggestions made and if you consider necessary you can implement them.
src/app/modules/shared/components/dropdown/dropdown.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/dropdown/dropdown.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/dropdown/dropdown.component.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/dropdown/dropdown.component.ts
Outdated
Show resolved
Hide resolved
…uttons associeted
kevinjlope
force-pushed
the
TT-290-Improve-status-active-inactive
branch
from
f8b36db to
b42c4c9
Compare
kevinjlope
changed the title
jase156
suggested changes
Jul 26, 2021
src/app/modules/activities-management/components/activity-list/activity-list.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/activities-management/components/activity-list/activity-list.component.scss
Outdated
Show resolved
Hide resolved
.../customer-management/components/projects/components/project-list/project-list.component.scss
Outdated
Show resolved
Hide resolved
.../customer-management/components/projects/components/project-list/project-list.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/activities-management/components/activity-list/activity-list.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/activities-management/components/activity-list/activity-list.component.scss
Outdated
Show resolved
Hide resolved
...management/components/customer-info/components/customer-list/customer-list.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/dropdown/dropdown.component.scss
Outdated
Show resolved
Hide resolved
src/app/modules/shared/components/dropdown/dropdown.component.scss
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
scastillo-jp
approved these changes
Jul 27, 2021
edgardavid2015
approved these changes
Jul 28, 2021
Contributor
edgardavid2015
left a comment
edgardavid2015
left a comment
There was a problem hiding this comment.
I already check this new features, and for me it works fine. The only observation that I have is in the word "associeted", is misspelled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is not very clear
I changed the style of the buttons