-
Notifications
You must be signed in to change notification settings - Fork 1
Tt 286 handle error message client width #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #704 +/- ##
==========================================
+ Coverage 93.09% 95.28% +2.18%
==========================================
Files 85 104 +19
Lines 1564 2099 +535
Branches 107 157 +50
==========================================
+ Hits 1456 2000 +544
+ Misses 67 56 -11
- Partials 41 43 +2
Continue to review full report at Codecov.
|
PieritoAlva95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work Kevin and Santiago. 👍🏼 💯 🥇
jase156
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job guys
Problem
Cannot read property 'clientWidth', this problem present in the section of Reports.

Solution
We added a new "Subscription" variable and its respective unsubscribe routine.