Skip to content

Conversation

bytesantiago
Copy link
Contributor

Problem

Cannot read property 'clientWidth', this problem present in the section of Reports.

Solution

We added a new "Subscription" variable and its respective unsubscribe routine.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #704 (719f14b) into master (13de42e) will increase coverage by 2.18%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   93.09%   95.28%   +2.18%     
==========================================
  Files          85      104      +19     
  Lines        1564     2099     +535     
  Branches      107      157      +50     
==========================================
+ Hits         1456     2000     +544     
+ Misses         67       56      -11     
- Partials       41       43       +2     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 63.63% <60.00%> (+8.08%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...dules/time-entries/pages/time-entries.component.ts 84.88% <82.85%> (+2.07%) ⬆️
...toggles/filters/feature-filter-provider.service.ts 93.33% <87.50%> (+15.55%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.77% <93.75%> (+12.56%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.79% <95.58%> (+8.61%) ⬆️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b069e...719f14b. Read the comment docs.

Copy link
Contributor

@PieritoAlva95 PieritoAlva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work Kevin and Santiago. 👍🏼 💯 🥇

Copy link
Contributor

@jase156 jase156 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job guys

@kevinjlope kevinjlope merged commit 56bb4e0 into master Jul 14, 2021
@kevinjlope kevinjlope deleted the TT-286-Handle-error-message-Client-width branch July 14, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants