Skip to content

Conversation

jase156
Copy link
Contributor

@jase156 jase156 commented Jul 7, 2021

Description:

A new feature has been added that allows you to view time entries in a calendar.

Month View:
image

Week View:
image

Day View:
image

To add this new feature:

  • We created a feature toggle to wrap the new feature
  • We added an external module called "Angular Calendar"
  • We have added a method for get the time difference in minutes within SubstractDatePipe
  • We have modified MonthPickerComponent so that the date can be updated from outside the component.

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #703 (8d988b4) into master (13de42e) will increase coverage by 2.40%.
The diff coverage is 97.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   93.09%   95.50%   +2.40%     
==========================================
  Files          85      105      +20     
  Lines        1564     2178     +614     
  Branches      107      166      +59     
==========================================
+ Hits         1456     2080     +624     
+ Misses         67       56      -11     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...toggles/filters/feature-filter-provider.service.ts 93.33% <87.50%> (+15.55%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.77% <93.75%> (+12.56%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.79% <95.58%> (+8.61%) ⬆️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b069e...8d988b4. Read the comment docs.

Copy link
Contributor

@jcalarcon98 jcalarcon98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job Javier 💥

@jase156 jase156 requested a review from jcalarcon98 July 9, 2021 04:22
Copy link
Contributor

@PieritoAlva95 PieritoAlva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the recommendations made by Jean Carlos and the review done by me, it is an excellent job, keep up the good work. 💯 👍🏼 🥇

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scastillo-jp scastillo-jp merged commit 3276054 into master Jul 15, 2021
@scastillo-jp scastillo-jp deleted the TT-279-Angular-calendar-implementation branch July 15, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants