Skip to content

Conversation

@jase156
Copy link
Contributor

@jase156 jase156 commented Jul 7, 2021

Description:

A new feature has been added that allows you to view time entries in a calendar.

Month View:
image

Week View:
image

Day View:
image

To add this new feature:

  • We created a feature toggle to wrap the new feature
  • We added an external module called "Angular Calendar"
  • We have added a method for get the time difference in minutes within SubstractDatePipe
  • We have modified MonthPickerComponent so that the date can be updated from outside the component.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2021

SonarCloud Quality Gate failed.

Bug B 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

@codecov
Copy link

codecov bot commented Jul 7, 2021

Codecov Report

Merging #702 (67b9ca6) into master (13de42e) will increase coverage by 2.39%.
The diff coverage is 97.30%.

❗ Current head 67b9ca6 differs from pull request most recent head 3a21393. Consider uploading reports for the commit 3a21393 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   93.09%   95.48%   +2.39%     
==========================================
  Files          85      105      +20     
  Lines        1564     2172     +608     
  Branches      107      166      +59     
==========================================
+ Hits         1456     2074     +618     
+ Misses         67       56      -11     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
...toggles/filters/feature-filter-provider.service.ts 93.33% <87.50%> (+15.55%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 88.00% <90.00%> (+5.18%) ⬆️
...project-list-hover/project-list-hover.component.ts 90.38% <92.00%> (+2.01%) ⬆️
.../components/project-list/project-list.component.ts 96.77% <93.75%> (+12.56%) ⬆️
src/app/modules/users/store/user.reducers.ts 94.73% <94.73%> (ø)
...ponents/details-fields/details-fields.component.ts 95.79% <95.58%> (+8.61%) ⬆️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b069e...3a21393. Read the comment docs.

@jase156 jase156 closed this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants