#19 change application colors #70

daros10 · 2020-04-01T02:23:40Z

PR related to change app style.

macrisguncay

Please, check your branch because you have some changes that already are merged in the master branch

macrisguncay · 2020-04-01T02:40:53Z

.prettierrc

+  "semi": true,
+  "bracketSpacing": true,
+  "endOfLine": "lf"
+}


I think that you are having problems getting master changes.. why do you have these changes.?

macrisguncay · 2020-04-01T02:42:25Z

README.md

+- `TSLint`
+- `Prettier - Code formatter`.
+- Go to user settings (`settings.json`) and enable formatting on save: `"editor.formatOnSave": true`.
+


this changes already are in master branch

macrisguncay · 2020-04-01T02:44:46Z

package.json

-    "@angular-devkit/build-angular": "^0.900.5",
-    "@angular/cli": "~9.0.4",
+    "@angular-devkit/build-angular": "^0.901.0",
+    "@angular/cli": "^9.1.0",


is this your local update.?

macrisguncay · 2020-04-01T02:49:17Z

src/app/modules/time-entries/pages/time-entries.component.scss

@@ -44,3 +44,8 @@
    cursor: pointer;
  }
 }
+
+.title-card {
+  background-image: linear-gradient(to left top, #fc5630, #fe503a, #ff4a44, #ff444d, #ff3f56);


I think that it is better if we can define palette colors.

daros10 · 2020-04-01T02:57:52Z

Please, check your branch because you have some changes that already are merged in the master branch

The problem is that it works with the last changes that were made in the branch that is not merged to be able to apply the changes of the styles to the functionalities that are not in master.

All tests also run correctly, but github in the log shows two tests fail in time-entries.component.spec.ts.

enriquezrene

You need to rebase this branch against master. Ask @macrisguncay for help, she can lend you a hand with this.
Remove the search project implementation since this is part of another ticket and we don't want to include more than one ticket per PR
There are some issues with the look and feel.
We are not using rounded corners for the components. Check the accepted design:

The username in the top right corner (no borders needed):

You implementation:

Original design:

Menu items are rectangles with no rounded corners.
Your implementation looks like:

Design looks like:

ioet colors don't have any green so button colors should not be green.
This is how clock-in button looks like:

Use this set of colors as reference:

You need to add some consistent colors for the texts here. The background-color should not be gray for sure.

Remove rounded corners here:

These buttons can not be blue, FInd a consistent color for them:

This looks really weird, please fix the styles:

Feel free to ask @jorgecod for help. He knows a lot about styling.

enriquezrene · 2020-04-01T03:58:24Z

src/app/modules/project-management/pages/project-management.component.spec.ts

@@ -44,14 +45,14 @@ describe('ProjectManagementComponent', () => {

  beforeEach(async(() => {
    TestBed.configureTestingModule({
-      declarations: [ ProjectManagementComponent, CreateProjectComponent, ProjectListComponent ],
-      providers: [ { provide: ProjectService, useValue: projectServiceStub }],
+      declarations: [ProjectManagementComponent, CreateProjectComponent, ProjectListComponent, FilterProjectPipe],


This PR only needs to contain the required styles for the app. Please remove this pipe implementation.

enriquezrene · 2020-04-01T03:59:15Z

src/app/modules/shared/components/search-project/search-project.component.spec.ts

+
+import { SearchProjectComponent } from './search-project.component';
+
+describe('SearchProjectComponent', () => {


remove this code since this is part of other ticket.

daros10 · 2020-04-01T09:06:37Z

You need to rebase this branch against master. Ask @macrisguncay for help, she can lend you a hand with this.

Remove the search project implementation since this is part of another ticket and we don't want to include more than one ticket per PR

There are some issues with the look and feel.
We are not using rounded corners for the components. Check the accepted design:

The username in the top right corner (no borders needed):

You implementation:

Original design:

Menu items are rectangles with no rounded corners.
Your implementation looks like:

Design looks like:

ioet colors don't have any green so button colors should not be green.
This is how clock-in button looks like:

Use this set of colors as reference:

You need to add some consistent colors for the texts here. The background-color should not be gray for sure.

Remove rounded corners here:

These buttons can not be blue, FInd a consistent color for them:

This looks really weird, please fix the styles:

Feel free to ask @jorgecod for help. He knows a lot about styling.

I have removed all the non-existent functionality in master and have corrected the observations.

daros10 requested a review from enriquezrene April 1, 2020 02:23

macrisguncay reviewed Apr 1, 2020

View reviewed changes

enriquezrene suggested changes Apr 1, 2020

View reviewed changes

daros10 added 14 commits April 1, 2020 01:29

#3 search active projects in view projects

e488233

#3 search active projects in view timeClockIn

6defa24

#3 added project service in list

f4304fe

#3 Added importation filter project

24fffd6

#50 added border error in inputs

dea7d20

#50 added validaition style in Activity page

741bfdd

#19 added navbar and sidebar styles

b390e14

#19 added styles in pages

3ec1568

#3 search active projects in view projects

541eeb8

#3 search active projects in view timeClockIn

bd595a9

#3 added project service in list

1521710

#3 Added importation filter project

d85cf09

#50 added border error in inputs

78fa129

#19 added styles in pages

dd7f132

daros10 force-pushed the #19-change-application-colors branch from c67635a to dd7f132 Compare April 1, 2020 06:51

#19 styles aplied based only in master branch

750f375

macrisguncay requested a review from enriquezrene April 1, 2020 18:32

macrisguncay mentioned this pull request Apr 1, 2020

#50 improve required field look and feel #62

Closed

daros10 closed this Apr 3, 2020

enriquezrene deleted the #19-change-application-colors branch April 9, 2020 21:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

#19 change application colors #70

#19 change application colors #70

Uh oh!

daros10 commented Apr 1, 2020

Uh oh!

macrisguncay left a comment

Uh oh!

macrisguncay Apr 1, 2020

Uh oh!

daros10 Apr 1, 2020

Uh oh!

macrisguncay Apr 1, 2020

Uh oh!

daros10 Apr 1, 2020

Uh oh!

macrisguncay Apr 1, 2020

Uh oh!

daros10 Apr 1, 2020

Uh oh!

macrisguncay Apr 1, 2020

Uh oh!

daros10 commented Apr 1, 2020 •

edited

Loading

Uh oh!

enriquezrene left a comment

Uh oh!

enriquezrene Apr 1, 2020

Uh oh!

daros10 Apr 1, 2020

Uh oh!

enriquezrene Apr 1, 2020

Uh oh!

daros10 Apr 1, 2020

Uh oh!

daros10 commented Apr 1, 2020 •

edited

Loading

Uh oh!

Uh oh!


		import { SearchProjectComponent } from './search-project.component';

		describe('SearchProjectComponent', () => {

#19 change application colors #70

#19 change application colors #70

Uh oh!

Conversation

daros10 commented Apr 1, 2020

Uh oh!

macrisguncay left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daros10 commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enriquezrene left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daros10 commented Apr 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

daros10 commented Apr 1, 2020 •

edited

Loading

daros10 commented Apr 1, 2020 •

edited

Loading