TT-264 UI test coverage #699
Conversation
kevinjlope
requested review from
jase156,
jcalarcon98,
PieritoAlva95 and
scastillo-jp
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 93.09% 95.30% +2.21%
==========================================
Files 85 104 +19
Lines 1564 2089 +525
Branches 107 155 +48
==========================================
+ Hits 1456 1991 +535
+ Misses 67 56 -11
- Partials 41 42 +1
Continue to review full report at Codecov.
|
|
@mrkevinomar in my localist host using your branch I have problems with the test: |
| component.ngOnDestroy(); | ||
|
|
||
| expect(subscription).toHaveBeenCalledTimes(1); | ||
|
|
There was a problem hiding this comment.
dete this line white
| component.ngOnDestroy(); | ||
|
|
||
| expect(subscriptionProjectTypes).toHaveBeenCalledTimes(1); | ||
|
|
There was a problem hiding this comment.
delete this line white
| @@ -136,6 +144,7 @@ describe('ProjectListComponent', () => { | |||
| spyOn(component, 'openModal'); | |||
| component.switchStatus(itemData); | |||
| expect(component.openModal).toHaveBeenCalled(); | |||
|
|
|||
There was a problem hiding this comment.
delete this line white
| import { UserService } from './user.service'; | ||
| import { HttpClientTestingModule, HttpTestingController } from '@angular/common/http/testing'; | ||
|
|
||
|
|
There was a problem hiding this comment.
delete this line-white
|
Kudos, SonarCloud Quality Gate passed!
|
In this PR, I added some unit testing in the methods that were not tested, and I removed the unit testing that was unnecessary in the project.