fix: TT-262 disable buttons futures in time entries and disable input date futures #697
Conversation
…-date futures in reports, test of method monthEnable
kevinjlope
requested review from
scastillo-jp,
jase156,
lenshinoda,
jcalarcon98 and
PieritoAlva95
…-date futures in reports, test of method monthEnable
scastillo-jp
force-pushed
the
TT-262-No-select-future-dates-in-the-page-Reports
branch
from
3d930d5 to
c9423a8
Compare
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 93.09% 94.07% +0.98%
==========================================
Files 85 104 +19
Lines 1564 2094 +530
Branches 107 155 +48
==========================================
+ Hits 1456 1970 +514
- Misses 67 81 +14
- Partials 41 43 +2
Continue to review full report at Codecov.
|
.gitignore
Outdated
| @@ -44,6 +44,7 @@ testem.log | |||
| keys.ts | |||
| src/environments/keys.ts | |||
| debug.log | |||
| /.vscode | |||
There was a problem hiding this comment.
In this part you can use *.vscode
| @@ -69,4 +68,14 @@ describe('MonthPickerComponent', () => { | |||
| expect(component.selectDate).toHaveBeenCalledWith(monthSelect, yearSelect); | |||
| }); | |||
|
|
|||
| it('monthEnable set disable true in the buttoms futures', () => { | |||
There was a problem hiding this comment.
replace this name:
monthEnable sets disabled to true on futures months
| expect(component.monthEnable(monthFuture)).toBeTrue(); | ||
| }); | ||
|
|
||
| it('monthEnable set disable false in the buttoms presents and past', () => { |
There was a problem hiding this comment.
this description is not very clear:
I Understand this.
monthEnable set disabled to false in the months presents and past
I Think is no necessary disable the past months only future months
…f github.com:ioet/time-tracker-ui into TT-262-No-select-future-dates-in-the-page-Reports
|
Kudos, SonarCloud Quality Gate passed!
|
This time, there is not any problem, but the objective is to disable buttons futures of component month picker, in this component added the method monthEnable. Also, disable input date futures of the dashboard of the reports, in this component added the method getCurrentDate.
Finally added two Unit testing of the method monthEnable, because this method disables buttons futures(Months futures) and enables buttons present or past(Months past/present).