fix: TT-91 Time out of the penultimate entry overlaps the entry that is running #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me entry that is running
lenshinoda
requested review from
scastillo-jp,
jase156,
jcalarcon98 and
kevinjlope
Codecov Report
@@ Coverage Diff @@
## master #695 +/- ##
==========================================
+ Coverage 93.09% 94.09% +1.00%
==========================================
Files 85 104 +19
Lines 1564 2084 +520
Branches 107 153 +46
==========================================
+ Hits 1456 1961 +505
- Misses 67 81 +14
- Partials 41 42 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
scastillo-jp
reviewed
Jun 4, 2021
| component.entryId = newRunningEntry.id; | ||
| spyOn(component, 'doSave'); | ||
|
|
||
| const startDateModified = new Date(2021, 6, 1, 10, 50); |
There was a problem hiding this comment.
Is correct this format?
scastillo-jp
approved these changes
Jun 7, 2021
jase156
approved these changes
Jun 7, 2021
lenshinoda
deleted the
TT-91-The-time-out-of-the-penultimate-time-entry-overlaps-the-time-entry-that-is-running
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: TT-91 The time out of the penultimate time entry overlaps the time entry that is running
Added a condtion to save the entry in time-entries component and the problem is solved.