Skip to content

Conversation

jcalarcon98
Copy link
Contributor

Description

Currently the Backend response from the endpoint:

<time-tracker-backend-url>/projects/<project-id>

has the following structure:

{
    "customer_name": "JAND, Inc., DBA Warby Parker",
    "customer": {
        "name": "JAND, Inc., DBA Warby Parker",
        "description": ""
    },
    "project_type": {
        "name": "QA",
        "description": "Projects in which most work is creating and/or running test or setting up test infrastructure."
    },
   ...
},

In the future customer_name field will be removed, now we have to access the customer name through customer field like

project.customer.name

With this pull request this Behavior has been achieved.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #694 (3ca87ff) into master (13de42e) will increase coverage by 1.02%.
The diff coverage is 93.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   93.09%   94.11%   +1.02%     
==========================================
  Files          85      104      +19     
  Lines        1564     2074     +510     
  Branches      107      150      +43     
==========================================
+ Hits         1456     1952     +496     
- Misses         67       81      +14     
  Partials       41       41              
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
.../components/project-list/project-list.component.ts 65.78% <52.17%> (-18.43%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a570617...3ca87ff. Read the comment docs.

@jcalarcon98 jcalarcon98 merged commit ac24beb into master Jun 3, 2021
@jcalarcon98 jcalarcon98 deleted the TT-259-validate-call-to-costumer-on-project branch June 3, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants