Skip to content

Conversation

kevinjlope
Copy link
Contributor

### Problem:
There is an error when adding a new entry select a project and click on the check "I am working on this", the dashboard shows the time in "00:00".

### Solutions:
In the method projectSelected the variable star_date sets the time in how 00:00, this is a data burned. We need to change the data.

@scastillo-jp scastillo-jp force-pushed the TT-258-check-working-on-this-view-current-hour branch from ad6bc4d to 82d5f87 Compare June 3, 2021 19:58
@@ -125,7 +125,7 @@ export class TimeEntriesComponent implements OnInit, OnDestroy {
uri: dataToUse.uri ? dataToUse.uri : '',
activity_id: dataToUse.activity_id,
project_id: dataToUse.project_id,
start_date: startDate,
start_date: new Date(),
end_date: startDate
Copy link
Contributor

@jase156 jase156 Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should change constant's the name of the startDate to endDate for better readability.

@scastillo-jp scastillo-jp force-pushed the TT-258-check-working-on-this-view-current-hour branch 2 times, most recently from 331697e to bd32cf2 Compare June 11, 2021 16:48
@kevinjlope kevinjlope force-pushed the TT-258-check-working-on-this-view-current-hour branch from bd32cf2 to 7610e57 Compare June 11, 2021 17:06
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #693 (2421a9e) into master (13de42e) will increase coverage by 0.93%.
The diff coverage is 93.43%.

❗ Current head 2421a9e differs from pull request most recent head 9cad28c. Consider uploading reports for the commit 9cad28c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   93.09%   94.03%   +0.93%     
==========================================
  Files          85      104      +19     
  Lines        1564     2095     +531     
  Branches      107      156      +49     
==========================================
+ Hits         1456     1970     +514     
- Misses         67       81      +14     
- Partials       41       44       +3     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
.../components/project-list/project-list.component.ts 65.78% <52.17%> (-18.43%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...ared/components/input-date/input-date.component.ts 66.66% <66.66%> (-2.57%) ⬇️
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 84.88% <82.85%> (+2.07%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b581c2e...9cad28c. Read the comment docs.

@scastillo-jp scastillo-jp force-pushed the TT-258-check-working-on-this-view-current-hour branch from e8fbe19 to 86ccb94 Compare June 16, 2021 13:43
@kevinjlope kevinjlope force-pushed the TT-258-check-working-on-this-view-current-hour branch from 86ccb94 to 9cad28c Compare June 16, 2021 13:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scastillo-jp scastillo-jp merged commit 20f1793 into master Jun 16, 2021
@scastillo-jp scastillo-jp deleted the TT-258-check-working-on-this-view-current-hour branch June 16, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants