-
Notifications
You must be signed in to change notification settings - Fork 1
fix: TT-258 Click on the check I am working on this #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TT-258 Click on the check I am working on this #693
Conversation
ad6bc4d
to
82d5f87
Compare
@@ -125,7 +125,7 @@ export class TimeEntriesComponent implements OnInit, OnDestroy { | |||
uri: dataToUse.uri ? dataToUse.uri : '', | |||
activity_id: dataToUse.activity_id, | |||
project_id: dataToUse.project_id, | |||
start_date: startDate, | |||
start_date: new Date(), | |||
end_date: startDate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should change constant's the name of the startDate to endDate for better readability.
331697e
to
bd32cf2
Compare
bd32cf2
to
7610e57
Compare
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 93.09% 94.03% +0.93%
==========================================
Files 85 104 +19
Lines 1564 2095 +531
Branches 107 156 +49
==========================================
+ Hits 1456 1970 +514
- Misses 67 81 +14
- Partials 41 44 +3
Continue to review full report at Codecov.
|
src/app/modules/time-entries/pages/time-entries.component.spec.ts
Outdated
Show resolved
Hide resolved
e8fbe19
to
86ccb94
Compare
86ccb94
to
9cad28c
Compare
Kudos, SonarCloud Quality Gate passed!
|
### Problem:
There is an error when adding a new entry select a project and click on the check "I am working on this", the dashboard shows the time in "00:00".
### Solutions:
In the method projectSelected the variable star_date sets the time in how 00:00, this is a data burned. We need to change the data.