Skip to content

Conversation

lenshinoda
Copy link
Collaborator

This pull request solves the problem "TypeError: Cannot read property 'map' of undefined" that some pull request were haveing while CI/CD process

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #690 (d6888b3) into master (13de42e) will increase coverage by 0.53%.
The diff coverage is 93.23%.

❗ Current head d6888b3 differs from pull request most recent head 9379967. Consider uploading reports for the commit 9379967 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   93.09%   93.63%   +0.53%     
==========================================
  Files          85      103      +18     
  Lines        1564     2042     +478     
  Branches      107      148      +41     
==========================================
+ Hits         1456     1912     +456     
- Misses         67       88      +21     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
.../components/project-list/project-list.component.ts 65.78% <52.17%> (-18.43%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9082b90...9379967. Read the comment docs.

@scastillo-jp scastillo-jp merged commit 459f467 into master May 27, 2021
@scastillo-jp scastillo-jp deleted the TT-253-Test-Cannot-read-property-map-of-undefined branch May 27, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants