Skip to content

TT-41 save technologies as part of project #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

TT-41 save technologies as part of project #687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5f670f2
fix: TT-41 Add column in table of projects, also agg and change some …
kevinjlope May 20, 2021
287a5aa
fix: TT-41 Add column in table of projects, also agg and change some …
kevinjlope May 20, 2021
eb677be
fix: TT-41 review and small change/correction of test
kevinjlope May 24, 2021
5fb9e55
fix: TT-41 latest changes
kevinjlope May 25, 2021
2da046b
fix: TT-41 code small
kevinjlope May 25, 2021
459f467
fix: Test Cannot read property 'map' of undefined. (#690)
lenshinoda May 27, 2021
94ce9d5
chore(release): 1.44.3 [skip ci]nn
semantic-release-bot May 27, 2021
864bce8
fix: TT-41 Add column in table of projects, also agg and change some …
kevinjlope May 20, 2021
b7af502
fix: TT-41 Add column in table of projects, also agg and change some …
kevinjlope May 20, 2021
cf621a6
fix: TT-41 review and small change/correction of test
kevinjlope May 24, 2021
fa5af7d
fix: TT-41 latest changes
kevinjlope May 25, 2021
8df5c79
fix: TT-41 code small
kevinjlope May 25, 2021
2ed3335
fix: TT-41 last revision of changes
kevinjlope May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: TT-41 review and small change/correction of test
  • Loading branch information
@kevinjlope
kevinjlope committed May 24, 2021
commit eb677be7f654cc23d8d40ede5d1203e7bb3cd752
2 changes: 1 addition & 1 deletion ...stomer-management/components/projects/components/project-list/project-list.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<tr class="d-flex" *ngFor="let project of projects">
<td class="col-sm-3">{{ project.id }}</td>
<td class="col-sm-3">{{ project.name }}</td>
<td class="col-sm-2">{{ project.technologies }}</td>
<td class="col-sm-2">{{ project.technologies ? project.technologies.toString() : ""}}</td>
<td class="col-sm-2">{{ getProjectTypeName(project.project_type_id) }}</td>
<td class="col-sm-1 text-center">
<button type="button" class="btn btn-sm btn-primary" (click)="updateProject(project)">
Expand Down
8 changes: 5 additions & 3 deletions ...mer-management/components/projects/components/project-list/project-list.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('ProjectListComponent', () => {
let getCustomerProjectsSelectorMock;
let allCustomerProjectsSelectorMock;

const project = { id: '123', name: 'aaa', description: 'xxx', project_type_id: '1234', status: 'inactive' };
const project = { id: '123', name: 'aaa', description: 'xxx', project_type_id: '1234', technologies: ['python', 'angular'], status: 'inactive' };

const state: ProjectState = {
projects: [project],
Expand Down Expand Up @@ -124,6 +124,7 @@ describe('ProjectListComponent', () => {
name: 'aaa',
description: 'xxx',
project_type_id: '1234',
technologies: ['python', 'angular'],
status: 'activate',
key: 'activate',
_status: false,
Expand All @@ -143,6 +144,7 @@ describe('ProjectListComponent', () => {
name: 'aaa',
description: 'xxx',
project_type_id: '1234',
technologies: ['python', 'angular'],
status: 'inactive',
key: 'inactive',
_status: true,
Expand Down Expand Up @@ -186,10 +188,10 @@ describe('ProjectListComponent', () => {
expect(tableRows.length).toBe(2);

const headerRow = tableRows[0];
expect(headerRow.cells[2].innerHTML).toBe('Project Type');
expect(headerRow.cells[3].innerHTML).toBe('Project Type');

const dataRow = tableRows[1];
expect(dataRow.cells[2].innerHTML).toBe('BK');
expect(dataRow.cells[3].innerHTML).toBe('BK');

done();
});
Expand Down
1 change: 1 addition & 0 deletions ...customer-management/components/projects/components/project-list/project-list.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import * as actions from '../store/project.actions';
import { ProjectUI } from '../../../../../shared/models/project.model';
import { allProjectTypes, ProjectTypeState } from '../../../projects-type/store';
import { ProjectType } from 'src/app/modules/shared/models';
import { runInThisContext } from 'vm';

@Component({
selector: 'app-project-list',
Expand Down