Skip to content

Conversation

@thegreatyamori
Copy link
Collaborator

We found a bug when changing the value of the goingToWorkOnThis variable in ngOnChanges, it was setting a value to undefined because the object being checked did not have the property at the time of adding a new time entry. We fixed the error using "Nullish coalescing operator" in addition to correcting the bug mentioned in the ticket.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #681 (c9a172e) into master (13de42e) will increase coverage by 1.12%.
The diff coverage is 94.43%.

❗ Current head c9a172e differs from pull request most recent head 7528449. Consider uploading reports for the commit 7528449 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   93.09%   94.22%   +1.12%     
==========================================
  Files          85      103      +18     
  Lines        1564     1991     +427     
  Branches      107      141      +34     
==========================================
+ Hits         1456     1876     +420     
- Misses         67       75       +8     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
.../components/entry-fields/entry-fields.component.ts 93.15% <89.74%> (-6.85%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c757b7e...7528449. Read the comment docs.

Copy link
Contributor

@jeffqev jeffqev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, It works fine

@scastillo-jp scastillo-jp merged commit d589221 into master May 10, 2021
@scastillo-jp scastillo-jp deleted the TT-236-when-you-add-a-new-entry-and-check-im-working-on-this-you-should-take-the-current-time-for-time-in branch May 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants