Skip to content

Conversation

@juanultimate
Copy link
Contributor

@juanultimate juanultimate requested a review from diegotony May 5, 2021 15:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #680 (49be26b) into master (13de42e) will increase coverage by 1.12%.
The diff coverage is 94.42%.

❗ Current head 49be26b differs from pull request most recent head 0e0d2fe. Consider uploading reports for the commit 0e0d2fe to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   93.09%   94.22%   +1.12%     
==========================================
  Files          85      103      +18     
  Lines        1564     1991     +427     
  Branches      107      141      +34     
==========================================
+ Hits         1456     1876     +420     
- Misses         67       75       +8     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
.../components/entry-fields/entry-fields.component.ts 93.15% <89.74%> (-6.85%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ea798...0e0d2fe. Read the comment docs.

@juanultimate juanultimate merged commit c757b7e into master May 5, 2021
@juanultimate juanultimate deleted the patching-karma branch May 5, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants