Skip to content

Conversation

jeffqev
Copy link
Contributor

@jeffqev jeffqev commented May 4, 2021

Projects can be archived or activated

Don't allow deleting projects

}
}

setActive(status: any): string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a redundant method.
the status variable can return 'inactive' | 'active' or only 'inactive'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases the endpoint return active or null for active items so there I make sure just return active or inactive

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, okay. I understand it !

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #679 (917aa02) into master (13de42e) will increase coverage by 1.17%.
The diff coverage is 94.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #679      +/-   ##
==========================================
+ Coverage   93.09%   94.26%   +1.17%     
==========================================
  Files          85      103      +18     
  Lines        1564     2023     +459     
  Branches      107      143      +36     
==========================================
+ Hits         1456     1907     +451     
- Misses         67       76       +9     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
.../components/project-list/project-list.component.ts 85.18% <81.81%> (+0.97%) ⬆️
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ea798...917aa02. Read the comment docs.

@jeffqev jeffqev merged commit 403bf3c into master May 6, 2021
@jeffqev jeffqev deleted the TT-218-Dont-allow-deleting-projects branch May 6, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants