-
Notifications
You must be signed in to change notification settings - Fork 1
Tt 218 dont allow deleting projects #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
} | ||
|
||
setActive(status: any): string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a redundant method.
the status variable can return 'inactive'
| 'active'
or only 'inactive'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases the endpoint return active or null
for active items so there I make sure just return active or inactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, okay. I understand it !
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
+ Coverage 93.09% 94.26% +1.17%
==========================================
Files 85 103 +18
Lines 1564 2023 +459
Branches 107 143 +36
==========================================
+ Hits 1456 1907 +451
- Misses 67 76 +9
+ Partials 41 40 -1
Continue to review full report at Codecov.
|
Projects can be archived or activated