Skip to content

Conversation

thegreatyamori
Copy link
Collaborator

I have refactored the logic of the difference presentation and corrected the bug

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #678 (9ce7996) into master (13de42e) will increase coverage by 1.14%.
The diff coverage is 94.56%.

❗ Current head 9ce7996 differs from pull request most recent head 655de0f. Consider uploading reports for the commit 655de0f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   93.09%   94.24%   +1.14%     
==========================================
  Files          85      103      +18     
  Lines        1564     1998     +434     
  Branches      107      144      +37     
==========================================
+ Hits         1456     1883     +427     
- Misses         67       75       +8     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
.../components/entry-fields/entry-fields.component.ts 93.15% <89.74%> (-6.85%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34a6e9e...655de0f. Read the comment docs.

@LEON12699
Copy link
Member

good job .. !! 🚀

@thegreatyamori thegreatyamori merged commit 999fb0d into master May 6, 2021
@thegreatyamori thegreatyamori deleted the TT-38-fix-pipe-to-calculate-difference-between-time-out-and-time-in branch May 6, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants