Skip to content

Conversation

eduardisrael
Copy link
Contributor

TT-226

This PR implement 'When the user tries to save, an error message should be shown that the clock out time can’t be before the clock in time'.

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #674 (114323c) into master (13de42e) will increase coverage by 1.07%.
The diff coverage is 94.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
+ Coverage   93.09%   94.16%   +1.07%     
==========================================
  Files          85      103      +18     
  Lines        1564     1988     +424     
  Branches      107      141      +34     
==========================================
+ Hits         1456     1872     +416     
- Misses         67       75       +8     
  Partials       41       41              
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...-management/store/activity-management.selectors.ts 77.77% <66.66%> (-9.73%) ⬇️
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
...app/modules/login/services/azure.ad.b2c.service.ts 80.00% <85.71%> (-2.36%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2126f...114323c. Read the comment docs.

@eduardisrael eduardisrael requested a review from LEON12699 April 30, 2021 15:01
Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job !!

@LEON12699
Copy link
Member

LGTM 🚀 !

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@eduardisrael eduardisrael merged commit 8a713d4 into master May 3, 2021
@eduardisrael eduardisrael deleted the TT-226-show-user-an-error-message-when-the-start-time-is-after-the-end-time branch May 3, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants